UI for setting the reason why SHF is waiting on an applicant

app/assets/stylesheets/member-app-waiting-reason.scss

@@ -1,7 +1,12 @@
-.member_app_waiting_reasons {
+#member_app_waiting_reasons {
 
-  input.wpcf7-form-control.is-custom {
-    width: 3rem;
+  select {
+    height: 110%;
+  }
+
+  input[type="text"]{
+    padding: 0.3rem 0.3rem;
+    width: 35rem;
   }
 
 }

app/controllers/membership_applications_controller.rb

@@ -16,7 +16,7 @@ def index
     authorize MembershipApplication
 
     action_params, @items_count, items_per_page =
-      process_pagination_params('membership_application')
+        process_pagination_params('membership_application')
 
     @search_params = MembershipApplication.ransack(action_params)
 
@@ -67,17 +67,47 @@ def update
 
         check_and_mark_if_ready_for_review params['membership_application'] if params.fetch('membership_application', false)
 
-        helpers.flash_message(:notice, t('.success'))
-        render :show
+        respond_to do |format|
+          format.js do
+            render partial: 'membership_applications/reason_waiting'
+          end
+
+          format.html do
+            helpers.flash_message(:notice, t('.success'))
+            render :show
+          end
+
+        end
 
       else
-        helpers.flash_message(:alert, t('.error'))
-        redirect_to edit_membership_application_path(@membership_application)
+        respond_to do |format|
+
+          format.html do
+            helpers.flash_message(:alert, t('.error'))
+            redirect_to edit_membership_application_path(@membership_application)
+          end
+
+          format.js do
+            render :json => @membership_application.errors, :status => :unprocessable_entity
+          end
+
+        end
       end
 
     else
-      helpers.flash_message(:alert, t('.error'))
-      redirect_to edit_membership_application_path(@membership_application)
+      respond_to do |format|
+
+        format.html do
+          helpers.flash_message(:alert, t('.error'))
+          redirect_to edit_membership_application_path(@membership_application)
+        end
+
+        format.js do
+          render :json => @membership_application.errors, :status => :unprocessable_entity
+        end
+
+      end
+
     end
   end
 
@@ -95,7 +125,7 @@ def information
 
 
   def destroy
-    @membership_application = MembershipApplication.find(params[:id])  # we don't need to fetch the categories
+    @membership_application = MembershipApplication.find(params[:id]) # we don't need to fetch the categories
     @membership_application.destroy
     redirect_to membership_applications_url, notice: t('membership_applications.application_deleted')
   end
@@ -132,21 +162,30 @@ def need_info
 
 
   def cancel_need_info
+
+    # empty out the reason for waiting info
+    @membership_application.waiting_reason = nil
+    @membership_application.custom_reason_text = nil
+
     simple_state_change(:cancel_waiting_for_applicant!, t('.success'), t('.error'))
   end
 
+
   def need_payment
     simple_state_change(:ask_for_payment!, t('.success'), t('.error'))
   end
 
+
   def cancel_need_payment
     simple_state_change(:cancel_waiting_for_payment!, t('.success'), t('.error'))
   end
 
+
   def received_payment
     simple_state_change(:received_payment!, t('.success'), t('.error'))
   end
 
+
   private
   def membership_application_params
     params.require(:membership_application).permit(*policy(@membership_application || MembershipApplication).permitted_attributes)

app/helpers/membership_applications_helper.rb

@@ -4,8 +4,54 @@ def can_edit_state?
     policy(@membership_application).permitted_attributes_for_edit.include? :state
   end
 
+
   def member_full_name
     @membership_application ? "#{@membership_application.first_name} #{@membership_application.last_name}" : '..'
 
   end
+
+
+  # the method to use to get the name for a reason, given the locale
+  # If no locale is given, the current locale is used.
+  # If the locale given isn't found or defined, the default name method is used
+  def reason_name_method(locale = I18n.locale)
+    reason_method 'name', locale
+  end
+
+
+  # the method to use to get the description for a reason, given the locale
+  # If no locale is given, the current locale is used.
+  # If the locale given isn't found or defined, the default name method is used
+  def reason_desc_method(locale = I18n.locale)
+    reason_method 'description', locale
+  end
+
+
+  # a collection of arrays with [the name of the reasons for waiting, the reason (object)]
+  # in the locale
+  def reasons_for_waiting_names(use_locale = I18n.locale)
+    reasons_for_waiting_info('name', use_locale)
+  end
+
+
+  # a collection of arrays with [the descriptions of the reasons for waiting,  the reason (object)]
+  # in the locale
+  def reasons_for_waiting_descs(use_locale = I18n.locale)
+    reasons_for_waiting_info('description', use_locale)
+  end
+
+
+  private
+
+  def reason_method(method_prefix, locale)
+    possible_method = "#{method_prefix}_#{locale}".to_sym
+    method_name = (AdminOnly::MemberAppWaitingReason.new.respond_to?(possible_method) ? possible_method : AdminOnly::MemberAppWaitingReason.send("default_#{method_prefix}_method".to_sym))
+  end
+
+
+  def reasons_for_waiting_info(method_prefix, locale)
+    method_name = reason_method(method_prefix, locale)
+    AdminOnly::MemberAppWaitingReason.all.map { |r| [r.id, r.send(method_name)] }
+  end
+
 end

app/models/admin_only/member_app_waiting_reason.rb

@@ -12,15 +12,25 @@ def other_reason_placeholder?
 
 
     # This is effectively a CONSTANT that is used in the UI
-    def self.other_reason_name
-      I18n.t('admin_only.member_app_waiting_reasons.other_custom_reason')
+    def self.other_reason_name(locale = I18n.locale)
+      I18n.t('admin_only.member_app_waiting_reasons.other_custom_reason', locale)
     end
 
 
+    def self.other_reason_desc(locale = I18n.locale)
+      I18n.t('admin_only.member_app_waiting_reasons.other_custom_reason_desc', locale)
+    end
+
+
+
     def self.default_name_method
       :name_sv
     end
 
+    def self.default_description_method
+      :description_sv
+    end
+
   end
 
 end

app/models/membership_application.rb

@@ -23,6 +23,11 @@ class MembershipApplication < ApplicationRecord
   has_and_belongs_to_many :business_categories
   has_many :uploaded_files
 
+  belongs_to :waiting_reason, optional: true,
+             foreign_key: "member_app_waiting_reasons_id",
+             class_name: 'AdminOnly::MemberAppWaitingReason'
+
+
   validates_presence_of :first_name,
                         :last_name,
                         :company_number,

app/policies/membership_application_policy.rb

@@ -97,7 +97,7 @@ def user_owner_attributes
 
 
   def all_attributes
-    owner_attributes + [:membership_number]
+    owner_attributes + [:membership_number, :waiting_reason, :custom_reason_text, :member_app_waiting_reasons_id]
   end
 
 
@@ -121,4 +121,4 @@ def owner?
     user && @record.respond_to?(:user) && @record.user == user
   end
 
-end
+end

app/views/membership_applications/_application_status_form.html.haml

@@ -1,23 +1,31 @@
+- if @membership_application.waiting_for_applicant?
+  = render 'reason_waiting'
+
+
+
 #admin-change-status-buttons
   %p.header
     = "#{t('membership_applications.show.change_status')}:"
 
 
-  = button_to t('membership_applications.start_review_btn'), start_review_membership_application_path(@membership_application), {class: 'btn start-review', disabled: !(@membership_application.may_start_review?)}
+  .row
+    = button_to t('membership_applications.start_review_btn'), start_review_membership_application_path(@membership_application), {class: 'btn start-review', disabled: !(@membership_application.may_start_review?)}
+
+    = button_to t('membership_applications.accept_btn'), accept_membership_application_path(@membership_application), {class: 'btn accept', disabled: !(@membership_application.may_accept?)}
 
-  = button_to t('membership_applications.accept_btn'), accept_membership_application_path(@membership_application), {class: 'btn accept', disabled: !(@membership_application.may_accept?)}
+    = button_to t('membership_applications.reject_btn'), reject_membership_application_path(@membership_application), {class: 'btn reject', disabled: !(@membership_application.may_reject?)}
 
-  = button_to t('membership_applications.reject_btn'), reject_membership_application_path(@membership_application), {class: 'btn reject', disabled: !(@membership_application.may_reject?)}
+    = button_to t('membership_applications.ask_applicant_for_info_btn'), need_info_membership_application_path(@membership_application), {class: 'btn need-info', disabled: !(@membership_application.may_ask_applicant_for_info?)}
 
-  = button_to t('membership_applications.ask_applicant_for_info_btn'), need_info_membership_application_path(@membership_application), {class: 'btn need-info', disabled: !(@membership_application.may_ask_applicant_for_info?)}
+  .row
+    = button_to t('membership_applications.cancel_waiting_for_applicant_btn'), cancel_need_info_membership_application_path(@membership_application), {class: 'btn cancel-need-info', disabled: !(@membership_application.may_cancel_waiting_for_applicant?)}
 
-  = button_to t('membership_applications.cancel_waiting_for_applicant_btn'), cancel_need_info_membership_application_path(@membership_application), {class: 'btn cancel-need-info', disabled: !(@membership_application.may_cancel_waiting_for_applicant?)}
+    = button_to t('membership_applications.ask_applicant_for_payment_btn'), need_payment_membership_application_path(@membership_application), {class: 'btn need-payment', disabled: !(@membership_application.may_ask_for_payment?)}
 
-  = button_to t('membership_applications.ask_applicant_for_payment_btn'), need_payment_membership_application_path(@membership_application), {class: 'btn need-payment', disabled: !(@membership_application.may_ask_for_payment?)}
+    = button_to t('membership_applications.cancel_waiting_for_payment_btn'), cancel_need_payment_membership_application_path(@membership_application), {class: 'btn cancel_need-payment', disabled: !(@membership_application.may_cancel_waiting_for_payment?)}
 
-  = button_to t('membership_applications.cancel_waiting_for_payment_btn'), cancel_need_payment_membership_application_path(@membership_application), {class: 'btn cancel_need-payment', disabled: !(@membership_application.may_cancel_waiting_for_payment?)}
+    = button_to t('membership_applications.received_payment_btn'), received_payment_membership_application_path(@membership_application), {class: 'btn received-payment', disabled: !(@membership_application.may_received_payment?)}
 
-  = button_to t('membership_applications.received_payment_btn'), received_payment_membership_application_path(@membership_application), {class: 'btn received-payment', disabled: !(@membership_application.may_received_payment?)}
 
 %br
   - if !@membership_application.paid?

app/views/membership_applications/_reason_waiting.html.haml

@@ -0,0 +1,78 @@
+-# submit the changed reason via xhr (javascript) whenever the change from the )
+-#  Do not make user press a "save" or "submit" button for just these changes.
+= form_for @membership_application, html: { id: 'member_app_waiting_reasons', multipart: true}, url: membership_application_path do |f|
+  .row
+
+    .reason_waiting_information
+      .col-sm-4
+        = f.label( :member_app_waiting_reasons, t('membership_applications.need_info.reason_title'))
+        = f.collection_select(:member_app_waiting_reasons_id,
+                              AdminOnly::MemberAppWaitingReason.all,
+                              :id,
+                              reason_name_method,
+                              { include_blank: t('membership_applications.need_info.select_a_reason') },
+                              class: 'reason-waiting-list',
+                              data: { remote: true,
+                               url: membership_application_path,
+                               method: 'put' }  )
+
+
+      .col-sm-8
+        %div#other_text_field
+          = f.label( :reason_waiting_custom_text, t('membership_applications.need_info.other_reason_label') )
+          = f.text_field :custom_reason_text,
+          data: {remote: true, url: membership_application_path, method: 'put'}
+
+
+:javascript
+
+
+  let reason_select_list = $(".reason-waiting-list");
+
+  // Changing the value in the member_app_waiting_reasons_id select list
+  // will send an AJAX request to the controller with the newly selected value.
+  // The controller will send a JS message back (the callback).
+  // If the callback reported that everything was successful, we don't need to do anything.
+  // If the callback reported an error, display an error message.
+
+
+  reason_select_list.bind("ajax:error", function(evt, data, status, xhr){
+
+    alert( "#{I18n.t('membership_applications.update.error')}" )
+
+  });
+
+
+
+  // hide or show the text field for entering a custom reason
+  let hideOrShow = function() {
+
+    let showEm;
+    let selected_reason = $('#membership_application_member_app_waiting_reasons_id').find('option:selected').text();
+    let other_reason = '#{AdminOnly::MemberAppWaitingReason.other_reason_name}';
+    showEm =  other_reason === selected_reason;
+
+    if (!showEm &&   document.getElementById("membership_application_custom_reason_text") !== null ) {
+        // clear out any custom reason if the selected reason is not the custom reason
+        document.getElementById("membership_application_custom_reason_text").value = "";
+    }
+
+    $('#other_text_field').toggle(showEm);
+  };
+
+
+
+  let initialize_hide_or_show = (function() {
+
+    $('#other_text_field').hide(); // start with this hidden.
+
+    $('#membership_application_member_app_waiting_reasons_id').change(hideOrShow);
+
+    hideOrShow();
+  });
+
+
+
+  $(document).ready(initialize_hide_or_show);
+
+

app/views/membership_applications/_reason_waiting.js.erb

@@ -0,0 +1 @@
+<%# This file needs to be here because otherwise the controller will try to render the .html partial. We simply want to return 'success' to the javascript sender   %>

config/locales/en.yml

@@ -313,14 +313,13 @@ en:
 
     need_info:
       reason_title: Reason
-
       other_reason_label: "other reason:"
-      submit_button_label: "Save the reason"
-
+      select_a_reason: "Select a reason..."
 
       success: 'The application has been marked as needing info. (Send email to the applicant.)'
       error: "There was an error when trying to set the application to 'needing information.'"
 
+
     cancel_need_info:
       success: The application has been changed to no longer needing information from the applicant.
       error: "There was an error when trying to set the application to 'no longer needing information from the applicant.'"
@@ -677,6 +676,7 @@ en:
       list_all_member_app_waiting_reasons: "List all Waiting for Information Reasons"
 
       other_custom_reason: "Other (enter the reason)"
+      other_custom_reason_desc: ""
 
       delete_confirm: "Are you sure you want to delete the reason: %{name_sv} (%{name_en})?"
 

config/locales/sv.yml

@@ -316,13 +316,13 @@ sv:
 
     need_info:
       reason_title: Anledning
-
       other_reason_label: "Annan orsak"
-      submit_button_label: "Spara orsaken"
+      select_a_reason: "Välj en anledning..."
 
       success: 'Ansökan har markerats som: "Behöver kompletteras". (Skicka e-post till den sökande.)'
       error: 'Det uppstod ett fel när systemet försökte sätta status: "Behöver kompletteras".'
 
+
     cancel_need_info:
       success: Ansökan har ändrats och behöver ej längre kompletteras av sökande.
       error: 'Det uppstod ett fel när systemet försökte ångra status: "Behöver kompletteras".'
@@ -680,6 +680,7 @@ sv:
       list_all_member_app_waiting_reasons: "Lista alla orsaker"
 
       other_custom_reason: "Annat (skriv in orsaken)"
+      other_custom_reason_desc: ""
 
       delete_confirm: "Är du säker på att du vill radera orsaken: %{name_sv} (%{name_en})?"