Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bolt_app.py for verbose message output #41

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

johnnykfeng
Copy link
Contributor

created get_response_v2( ) to get the verbose output from the bot

replaced get_response with get_response_v2 inside def event_test(client, say, event)

created `get_response_v2( )` to get the verbose output from the bot

replaced `get_response` with `get_response_v2` inside `def event_test(client, say, event)`
@20001LastOrder
Copy link
Collaborator

I'm not sure replacing one function with another function call is a good idea, though... Maybe remove the ond get_response and change the verbose as a parameter to the function call so that it can be configured to give either verbose or not verbose output?

@20001LastOrder 20001LastOrder self-requested a review July 24, 2023 16:14
@johnnykfeng
Copy link
Contributor Author

johnnykfeng commented Jul 24, 2023

Okay, I did it this way to preserve the old function in case we want to change it back, but I can just replace easily it if that's makes it more clear.

@20001LastOrder
Copy link
Collaborator

This should address #31

@20001LastOrder
Copy link
Collaborator

20001LastOrder commented Jul 24, 2023

Okay, I did it this way to preserve the old function in case we want to change it back, but I can just replace easily it if that's makes it more clear.

Please do so, we can always rely on the commit history if something went wrong :)

@20001LastOrder 20001LastOrder linked an issue Jul 24, 2023 that may be closed by this pull request
Merged get_response_v2. Fixed log_formatter to handle "thoughts" without "command". Added a try-except block in case there are other formats I'm not aware of.
@johnnykfeng
Copy link
Contributor Author

@20001LastOrder made a new commit based on suggestions, please check them out when you have time

Copy link
Collaborator

@20001LastOrder 20001LastOrder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@20001LastOrder 20001LastOrder merged commit 6c84305 into Aggregate-Intellect:main Jul 25, 2023
@johnnykfeng johnnykfeng deleted the patch-1 branch August 21, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show the "thought process" in the slack thread
2 participants