Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input/output folder for blogger #384

Merged
merged 14 commits into from
May 31, 2024
Merged

Conversation

andytai7
Copy link
Contributor

Description

Added folders to specify inputs and outputs of the blogger. In addition, dynamic names to the output files.

Add directions for contributors. For example, do developers need to run poetry install after picking up these changes?

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Mention related GitHub and Linear issues. E.g. Closes #xxx or Fixes #xxx. Otherwise delete this section.

Checklists

To speed up the review process, please follow these checklists:

Development

  • The Pull Request is small and focused on one topic
  • Lint rules pass locally (make format && make lint)
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development (make test)
  • The changes generate no new warnings (or explain any new warnings and why they're ok)
  • Commit messages are detailed
  • Changed code is self-explanatory and/or I added comments
  • I updated the documentation (docstrings, /docs)
    See the testing guidelines for help on tests, especially those involving web services.

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • I have performed a self-review of my code
  • Issue from task tracker has a link to this pull request

💔 Thank you for submitting a pull request!

@amirfz
Copy link
Contributor

amirfz commented May 29, 2024

@artificialfintelligence do you want to do an initial review and if you're happy with changes @20001LastOrder can review and approve.

@artificialfintelligence
Copy link
Contributor

@amirfz Actually @andytai7 created a PR to merge with his own main branch and asked me to review that, which I did, so it's good to go. 👍 Going forward he's going to create PRs directly from development branches in his fork to the origin repo.

@20001LastOrder 20001LastOrder self-requested a review May 31, 2024 20:30
Copy link
Collaborator

@20001LastOrder 20001LastOrder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, it looks good to me

@20001LastOrder 20001LastOrder merged commit 699c2a9 into Aggregate-Intellect:main May 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants