Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PromptReconstructor to include llm parameter #383

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

Eyobyb
Copy link
Collaborator

@Eyobyb Eyobyb commented May 27, 2024

…ctor and method calls

Description

This pull request (PR) changes where the large language model (LLM) gets set up in the code. Right now, the LLM is initialized in a utility file, but with this change, it will be passed in by a higher-level class instead.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Mention related GitHub and Linear issues. E.g. Closes #xxx or Fixes #xxx. Otherwise delete this section.

Checklists

To speed up the review process, please follow these checklists:

Development

  • The Pull Request is small and focused on one topic
  • Lint rules pass locally (make format && make lint)
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development (make test)
  • The changes generate no new warnings (or explain any new warnings and why they're ok)
  • Commit messages are detailed
  • Changed code is self-explanatory and/or I added comments
  • I updated the documentation (docstrings, /docs)
    See the testing guidelines for help on tests, especially those involving web services.

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • I have performed a self-review of my code
  • Issue from task tracker has a link to this pull request

💔 Thank you for submitting a pull request!

@Eyobyb Eyobyb requested a review from saminegash May 27, 2024 12:49
@Eyobyb Eyobyb changed the title chore: Update PromptReconstructor to include llm parameter in constru… Update PromptReconstructor to include llm parameter in constru… May 28, 2024
@Eyobyb Eyobyb changed the title Update PromptReconstructor to include llm parameter in constru… Update PromptReconstructor to include llm parameter May 28, 2024
saminegash
saminegash previously approved these changes May 30, 2024
Copy link
Collaborator

@saminegash saminegash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saminegash
Copy link
Collaborator

Needed to be rebased to merge @Eyobyb

@Eyobyb Eyobyb requested a review from saminegash June 10, 2024 12:48
Copy link
Collaborator

@saminegash saminegash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

@amirfz amirfz merged commit 0237604 into Aggregate-Intellect:main Jun 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants