Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove scripts folder #381

Merged
merged 2 commits into from
May 28, 2024
Merged

remove scripts folder #381

merged 2 commits into from
May 28, 2024

Conversation

saminegash
Copy link
Collaborator

Description

Describe your pull request here. What does this change implement or fix? Include motivation and context, e.g. relevant logs, error output, etc.

Add directions for contributors. For example, do developers need to run poetry install after picking up these changes?

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Mention related GitHub and Linear issues. E.g. Closes #xxx or Fixes #xxx. Otherwise delete this section.

Checklists

To speed up the review process, please follow these checklists:

Development

  • [ x The Pull Request is small and focused on one topic
  • Lint rules pass locally (make format && make lint)
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development (make test)
  • The changes generate no new warnings (or explain any new warnings and why they're ok)
  • Commit messages are detailed
  • Changed code is self-explanatory and/or I added comments
  • I updated the documentation (docstrings, /docs)
    See the testing guidelines for help on tests, especially those involving web services.

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • I have performed a self-review of my code
  • Issue from task tracker has a link to this pull request

💔 Thank you for submitting a pull request!

@saminegash saminegash requested a review from oshoma May 24, 2024 14:44
@amirfz
Copy link
Contributor

amirfz commented May 27, 2024

@saminegash before merging this. we need to close #301 since we no longer need to run those scripts (the blog writer demo project is a replacement for this pipeline). but could you keep a copy of the transcript_summarizer_aws_lambda.py just in case we need it later? maybe email that file to me so that we have a backup of it in case we ever need it.

@amirfz amirfz requested review from amirfz and removed request for oshoma May 27, 2024 13:07
@saminegash
Copy link
Collaborator Author

I think we can get the copy from this github commit hash if we ever need it so I don't think we need to keep elsewhere.

@amirfz amirfz merged commit dc9a0db into main May 28, 2024
4 checks passed
@amirfz amirfz deleted the fix/remove-scripts-folder branch May 28, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants