Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add human in the loop for blog writer demo #379

Conversation

KulwantSinghYadav
Copy link

Description

To address #378

Add directions for contributors. For example, do developers need to run poetry install after picking up these changes?

Type of change

  • New feature (non-breaking change that adds functionality)

Related issues

Mention related GitHub and Linear issues. E.g. Closes #xxx or Fixes #xxx. Otherwise delete this section.

Checklists

To speed up the review process, please follow these checklists:

Development

  • The Pull Request is small and focused on one topic
  • Lint rules pass locally (make format && make lint)
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development (make test)
  • The changes generate no new warnings (or explain any new warnings and why they're ok)
  • Commit messages are detailed
  • Changed code is self-explanatory and/or I added comments
  • I updated the documentation (docstrings, /docs)
    See the testing guidelines for help on tests, especially those involving web services.

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • I have performed a self-review of my code
  • Issue from task tracker has a link to this pull request

💔 Thank you for submitting a pull request!

@20001LastOrder 20001LastOrder self-requested a review May 22, 2024 20:51
Copy link
Collaborator

@20001LastOrder 20001LastOrder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This looks great. Just fixed some minor things and it is ready to go.

@20001LastOrder 20001LastOrder merged commit 1165aa9 into Aggregate-Intellect:main May 23, 2024
1 check passed
@20001LastOrder
Copy link
Collaborator

BTW, I just noticed that the commit you made does not seem to be linked to your GitHub account. Maybe you want to check your email setting for git :) @KulwantSinghYadav

@KulwantSinghYadav
Copy link
Author

BTW, I just noticed that the commit you made does not seem to be linked to your GitHub account. Maybe you want to check your email setting for git :) @KulwantSinghYadav

Thank you @20001LastOrder will try to figure this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants