Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple vector db usage for shared memory #374

Merged
merged 1 commit into from
May 17, 2024
Merged

Allow multiple vector db usage for shared memory #374

merged 1 commit into from
May 17, 2024

Conversation

Eyobyb
Copy link
Collaborator

@Eyobyb Eyobyb commented May 13, 2024 •
edited
Loading

Description

Describe your pull request here. What does this change implement or fix? Include motivation and context, e.g. relevant logs, error output, etc.

Add directions for contributors. For example, do developers need to run poetry install after picking up these changes?

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Mention related GitHub and Linear issues. E.g. Closes #xxx or Fixes #xxx. Otherwise delete this section.

Checklists

To speed up the review process, please follow these checklists:

Development

  • The Pull Request is small and focused on one topic
  • Lint rules pass locally (make format && make lint)
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development (make test)
  • The changes generate no new warnings (or explain any new warnings and why they're ok)
  • Commit messages are detailed
  • Changed code is self-explanatory and/or I added comments
  • I updated the documentation (docstrings, /docs)
    See the testing guidelines for help on tests, especially those involving web services.

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • I have performed a self-review of my code
  • Issue from task tracker has a link to this pull request

💔 Thank you for submitting a pull request!

@Eyobyb Eyobyb changed the title sharedmemory Allow multiple vector db usage for shared memory May 16, 2024
@Eyobyb
sharedmemory
5be7d3a 
add test fixes

remove unwanted class

remove yaml file
@Eyobyb Eyobyb force-pushed the multiple_vector_store_shared_memory branch from 3668719 to 5be7d3a Compare May 16, 2024 09:28
20001LastOrder
20001LastOrder approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@20001LastOrder 20001LastOrder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this PR looks great, nice work! One note, since we are pushing to use Pydantic for all core components. I will create an issue to adapt the BaseVectorDB with Pydantic

@20001LastOrder 20001LastOrder merged commit 3b85843 into Aggregate-Intellect:main May 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@20001LastOrder 20001LastOrder 20001LastOrder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eyobyb @20001LastOrder