Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog-Writer Feature #358

Merged

Conversation

artificialfintelligence
Copy link
Contributor

@artificialfintelligence artificialfintelligence commented May 3, 2024

Description

Describe your pull request here. What does this change implement or fix? Include motivation and context, e.g. relevant logs, error output, etc.
First iteration of blog-writer AKA blogger (Work in Progress; this is the version I used in the May 3rd demo)

Add directions for contributors. For example, do developers need to run poetry install after picking up these changes?
I will write a proper how-to guide, but for now:
In addition to the instructions provided in the "PDF-Reader" demo, run:

pip install -r requirements.txt

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Mention related GitHub and Linear issues. E.g. Closes #xxx or Fixes #xxx. Otherwise delete this section.
Issue #285

Checklists

To speed up the review process, please follow these checklists:

Development

  • The Pull Request is small and focused on one topic
  • Lint rules pass locally (make format && make lint)
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development (make test)
  • The changes generate no new warnings (or explain any new warnings and why they're ok)
  • Commit messages are detailed
  • Changed code is self-explanatory and/or I added comments
  • I updated the documentation (docstrings, /docs)
    See the testing guidelines for help on tests, especially those involving web services.

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • I have performed a self-review of my code
  • Issue from task tracker has a link to this pull request

💔 Thank you for submitting a pull request!

@20001LastOrder 20001LastOrder self-requested a review May 6, 2024 03:01
@20001LastOrder
Copy link
Collaborator

@artificialfintelligence Could you add a readme briefly documenting the purpose and use of the blog writer?

@artificialfintelligence
Copy link
Contributor Author

@20001LastOrder Done! Please review.

@20001LastOrder
Copy link
Collaborator

Thanks for adding the tutorial @artificialfintelligence . Could you also add a README.md file and put the link to the tutorial in it?

@artificialfintelligence
Copy link
Contributor Author

@20001LastOrder And done. Please note the link should work once the PR is merged. I wasn't sure if it would be automatically updated if I referenced the blogger branch.

@@ -0,0 +1,6 @@
pdfminer.six
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot sherpa-ai as a dependency.? 😄

@20001LastOrder 20001LastOrder self-requested a review May 7, 2024 19:15
Copy link
Collaborator

@20001LastOrder 20001LastOrder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@20001LastOrder 20001LastOrder merged commit c5574ed into Aggregate-Intellect:main May 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants