Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/gha fix #353

Merged
merged 4 commits into from
May 2, 2024
Merged

Fix/gha fix #353

merged 4 commits into from
May 2, 2024

Conversation

saminegash
Copy link
Collaborator

@saminegash saminegash commented Apr 30, 2024

Description

Enable caching of poetry dependencies in github actions.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Fixes SHR-41

Checklists

To speed up the review process, please follow these checklists:

Development

  • The Pull Request is small and focused on one topic
  • Lint rules pass locally (make format && make lint)
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development (make test)
  • The changes generate no new warnings (or explain any new warnings and why they're ok)
  • Commit messages are detailed
  • Changed code is self-explanatory and/or I added comments
  • I updated the documentation (docstrings, /docs)
    See the testing guidelines for help on tests, especially those involving web services.

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • I have performed a self-review of my code
  • Issue from task tracker has a link to this pull request

💔 Thank you for submitting a pull request!

@saminegash saminegash requested a review from oshoma April 30, 2024 11:49
@oshoma
Copy link
Collaborator

oshoma commented Apr 30, 2024

Hi @saminegash, thanks for working on this.

I think we should try first using the built-in cache feature of the setup-python package. See https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#caching-packages in the section called "Caching poetry dependencies"... it looks like we can just say cache: 'poetry'.

See also https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#about-caching-workflow-dependencies

Copy link
Collaborator

@oshoma oshoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments about setup-python caching feature

@saminegash saminegash requested a review from oshoma April 30, 2024 13:54
Copy link
Collaborator

@oshoma oshoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, like this. Please change offline tests as well.

@saminegash saminegash requested a review from oshoma April 30, 2024 14:12
@oshoma oshoma merged commit a115d64 into main May 2, 2024
4 checks passed
@oshoma oshoma deleted the fix/gha-fix branch May 2, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants