Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/citation validation #341

Merged

Conversation

20001LastOrder
Copy link
Collaborator

@20001LastOrder 20001LastOrder commented Apr 16, 2024

Description

Add tests and fixes #306

Your checklist for this pull request

Thank you for submitting a pull request! To speed up the review process, please follow this checklist:

  • My Pull Request is small and focused on one topic so it can be reviewed easily
  • My code follows the style guidelines of this project (make format)
  • Commit messages are detailed
  • I have performed a self-review of my code
  • I commented hard-to-understand parts of my code
  • I updated the documentation (docstrings, /docs)
  • My changes generate no new warnings (or explain any new warnings and why they're ok)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass when I run pytest tests (offline mode)

Additional steps for code with networking dependencies:

💔Thank you!

Copy link
Collaborator

@saminegash saminegash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but i couldn't test it locally as my local env is not running.

Copy link
Collaborator

@saminegash saminegash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@amirfz amirfz requested a review from saminegash April 22, 2024 13:33
@20001LastOrder
Copy link
Collaborator Author

@saminegash Could you approve it if it looks good to you?

Copy link
Collaborator

@saminegash saminegash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amirfz amirfz merged commit e9ffea4 into Aggregate-Intellect:main Apr 23, 2024
1 check passed
@20001LastOrder 20001LastOrder deleted the fix/citation_validation branch May 9, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Citation Validation would fail if there is no citation
3 participants