Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reforamt citation validation with decoupling #303

Closed
wants to merge 1 commit into from

Conversation

ChenKua
Copy link
Contributor

@ChenKua ChenKua commented Feb 27, 2024

Your checklist for this pull request

Thank you for submitting a pull request! To speed up the review process, please follow this checklist:

  • My Pull Request is small and focused on one topic so it can be reviewed easily
  • My code follows the style guidelines of this project (make format)
  • Commit messages are detailed
  • I have performed a self-review of my code
  • I commented hard-to-understand parts of my code
  • I updated the documentation (docstrings, /docs)
  • My changes generate no new warnings (or explain any new warnings and why they're ok)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass when I run pytest tests (offline mode)

Additional steps for code with networking dependencies:

Description

Describe your pull request here.

What does this PR implement or fix? Explain.

If this PR resolves any currently open issues then mention them like this: Closes #xxx.
Github will close such issues automatically when your PR is merged into main.

Any relevant logs, error output, etc?

Any other comments? For example, will other contributors need to install new libraries via poetry install after picking up these changes?

💔Thank you!

@ChenKua
Copy link
Contributor Author

ChenKua commented Feb 27, 2024

@20001LastOrder

@Eyobyb
Copy link
Collaborator

Eyobyb commented Feb 29, 2024

can you describe what we expect on the change and is there a test to check it ?

@ChenKua
Copy link
Contributor Author

ChenKua commented Mar 1, 2024

@Eyobyb I make parse_output function much shorter than the original version. There is not new test for that because the functionality should remain the same

@oshoma
Copy link
Collaborator

oshoma commented Mar 27, 2024

This is replaced by #317 . Thanks @ChenKua for your work on this!

@oshoma oshoma closed this Mar 27, 2024
20001LastOrder added a commit that referenced this pull request Mar 28, 2024
Refactor citations to simplify code and improve docs (closes #303)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants