Docstring #290
Merged
Docstring #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is by mistake. I will separate them.
Kua Chen
From Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
发件人: Amir Feizpour ***@***.***>
发送时间: Friday, February 9, 2024 8:07:30 AM
收件人: Aggregate-Intellect/sherpa ***@***.***>
抄送: Kua Chen ***@***.***>; Mention ***@***.***>
主题: Re: [Aggregate-Intellect/sherpa] Docstring (PR #290)
@amirfz commented on this pull request.
@ChenKua<https://github.com/ChenKua> this PR includes some codes re math agent and also docstrings, is that what you intended to do?
―
Reply to this email directly, view it on GitHub<#290 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AN424NY5RTP7CE3TS7GADADYSYNRFAVCNFSM6AAAAABDASF52GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNZSGMZTIMZWHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@amirfz I have remove everything about the math. The remaining code is purely on doc strings |
amirfz
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Thank you for submitting a pull request! To speed up the review process, please follow this checklist:
make format)/docs)pytest tests(offline mode)Additional steps for code with networking dependencies:
pytest tests --external_api(online mode, making network calls)Description
Describe your pull request here.
What does this PR implement or fix? Explain.
If this PR resolves any currently open issues then mention them like this:
Closes #xxx.Github will close such issues automatically when your PR is merged into
main.Any relevant logs, error output, etc?
Any other comments? For example, will other contributors need to install new libraries via
poetry installafter picking up these changes?💔Thank you!