create shared memory with vector db , #251

Eyobyb · 2023-12-06T12:25:49Z

This pull request (PR) has been created to improve file handling by implementing the use of a vector database. Within the test, the addition of a file to the vector database has been simulated. Ultimately, the QA agent utilizes the vector shared memory to incorporate the file added to the vector database as one source of context."

change the agent to take user_type event ,
create a test that use qa agent to show sharedmemory with vector db usage. also mimic what a scraped text with metadata should look like.

to see the flow run the test https://github.com/Aggregate-Intellect/sherpa/pull/251/files#diff-132c4b20bf076e7e6982df6712460af96b03768ea0975b993ebbc209edba6cca

[resolves #235 ]

oshoma

Some initial comments.

I don't really understand the purpose of this PR or the related issue, so @20001LastOrder should do a deeper review.

src/sherpa_ai/config/__init__.py

src/sherpa_ai/connectors/vectorStorage.py

src/sherpa_ai/connectors/ChromaVectorStore.py

src/sherpa_ai/memory/shared_memory_with_vectordb.py

src/sherpa_ai/memory/vector_storage.py

src/sherpa_ai/connectors/vectorStorage.py

oshoma · 2024-02-07T17:39:05Z

I just ran the tests again, this time in debug mode to see what GPT is doing with the request. I confirmed the file is passed through to GPT. However if you look at the response in the attached log file (view it in VS Code for colors) you'll see that GPT ignores the file content. Its response starts with, "How to summarize a file", and then it talks about how to summarize a PDF with AI. That part of the response looks like it comes from Google Search.

Is that the expected behavior @20001LastOrder @Eyobyb ?

See 2024-02-07-shared-memory-test.log

On a separate note, the log also shows that Slack bolt app is running here, even though I am only running one specific test. I wonder how we can disable that.

20001LastOrder · 2024-02-07T17:43:30Z

Slack

@oshoma
The first question: I don't think this is expected. We will need some more investigation.

The second question about Slack Bolt App: I think this is expected because you just ran poetry run pytest and it automatically collects tests in the apps folder as well. If you run poetry run pytest tests it should only consider test cases in the sherpa package.

src/tests/integration_tests/test_qa_agent_with_vectorSharedMemory.py

oshoma · 2024-02-07T19:55:50Z

The second question about Slack Bolt App: I think this is expected because you just ran poetry run pytest and it automatically collects tests in the apps folder as well. If you run poetry run pytest tests it should only consider test cases in the sherpa package.

Got it, thanks. I guess just the act of collecting the tests runs bot = app.client.auth_test() in bolt_app.py, even though the tests themselves don't run.

oshoma · 2024-02-20T00:39:35Z

Next steps:

1 .This still requires investigation:

I just ran the tests again, this time in debug mode to see what GPT is doing with the request. I confirmed the file is passed through to GPT. However if you look at the response in the attached log file (view it in VS Code for colors) you'll see that GPT ignores the file content. Its response starts with, "How to summarize a file", and then it talks about how to summarize a PDF with AI. That part of the response looks like it comes from Google Search.

test_shared_memory_with_vector needs rework to run offline (no network, use mocks)

Eyobyb · 2024-02-21T13:13:29Z

Next steps:

1 .This still requires investigation:

I just ran the tests again, this time in debug mode to see what GPT is doing with the request. I confirmed the file is passed through to GPT. However if you look at the response in the attached log file (view it in VS Code for colors) you'll see that GPT ignores the file content. Its response starts with, "How to summarize a file", and then it talks about how to summarize a PDF with AI. That part of the response looks like it comes from Google Search.

test_shared_memory_with_vector needs rework to run offline (no network, use mocks)

I'm not sure where we discussed this before, but Percy confirmed that right now, we'll experience this issue because it always Google search tool as a qaAgent for any request, even if it already has the necessary information stored in its memory.

change the agent to take user_type event , create a test that use qa agent to show sharedmemory with vector db fix pr review fix review issues create shared memory with vector db , change the agent to take user_type event , create a test that use qa agent to show sharedmemory with vector db fix issues raised on pr review

oshoma

Some small change requests.
This PR has been open a long time. Please rebase on top of origin/main to pick up the latest changes from main.

src/tests/integration_tests/test_qa_agent_with_vectorSharedMemory.py

src/sherpa_ai/memory/belief.py

20001LastOrder

Please see the comments below. Thanks!

src/sherpa_ai/config/__init__.py

src/sherpa_ai/connectors/chroma_vector_store.py

src/sherpa_ai/memory/shared_memory_with_vectordb.py

src/tests/integration_tests/test_qa_agent_with_vector_shared_memory.py

20001LastOrder · 2024-04-03T22:01:16Z

I think everything else is ready for this PR, we need some comments/documentation in the .env_sample file for INDEX_NAME_FILE_STORAGE @Eyobyb

20001LastOrder

Please check the comments above

change the agent to take user_type event , create a test that use qa agent to show sharedmemory with vector db fix pr review fix review issues create shared memory with vector db , change the agent to take user_type event , create a test that use qa agent to show sharedmemory with vector db fix issues raised on pr review

src/sherpa_ai/connectors/chroma_vector_store.py

20001LastOrder

Sorry, I think I missed another comment above. Also, please rebase or merge the PR with the main branch so that the tests can be run.

change the agent to take user_type event , create a test that use qa agent to show sharedmemory with vector db fix pr review fix review issues create shared memory with vector db , change the agent to take user_type event , create a test that use qa agent to show sharedmemory with vector db fix issues raised on pr review

20001LastOrder

LGTM now

20001LastOrder

LGTM

Eyobyb requested review from 20001LastOrder and oshoma December 6, 2023 12:26

oshoma requested changes Dec 12, 2023

View reviewed changes

oshoma self-requested a review January 29, 2024 14:38

oshoma reviewed Feb 7, 2024

View reviewed changes

src/tests/integration_tests/test_qa_agent_with_vectorSharedMemory.py Outdated Show resolved Hide resolved

Eyobyb force-pushed the feature/sharedmemorywithvectordb branch from a498731 to 62017ac Compare February 26, 2024 13:31

Eyobyb requested a review from oshoma February 26, 2024 13:34

reformat the code

5f2b8fc

oshoma requested changes Feb 27, 2024

View reviewed changes

src/tests/integration_tests/test_qa_agent_with_vectorSharedMemory.py Outdated Show resolved Hide resolved

src/tests/integration_tests/test_qa_agent_with_vectorSharedMemory.py Outdated Show resolved Hide resolved

src/sherpa_ai/memory/belief.py Outdated Show resolved Hide resolved

fix offline testing

b20c197

Eyobyb requested a review from oshoma March 5, 2024 14:33

Eyobyb added 2 commits March 5, 2024 17:34

fix prompt

f7be774

remove redundant class

f5dd4f5

20001LastOrder requested changes Mar 25, 2024

View reviewed changes

Update ChromaVectorStore class and integration tests

feb9fb4

Eyobyb requested a review from 20001LastOrder April 2, 2024 10:18

reformat with make

b4529c4

20001LastOrder requested changes Apr 5, 2024

View reviewed changes

Eyobyb added 5 commits April 8, 2024 13:48

Add INDEX_NAME_FILE_STORAGE to .env-sample

d71eedb

reformat the code

e7c012c

fix offline testing

d6bc812

remove redundant class

b97c014

Eyobyb added 2 commits April 8, 2024 13:58

Update ChromaVectorStore class and integration tests

92ca2fa

reformat with make

78663a7

Eyobyb force-pushed the feature/sharedmemorywithvectordb branch from d1daac6 to 78663a7 Compare April 8, 2024 11:01

20001LastOrder reviewed Apr 8, 2024

View reviewed changes

src/sherpa_ai/connectors/chroma_vector_store.py Show resolved Hide resolved

20001LastOrder requested changes Apr 8, 2024

View reviewed changes

Eyobyb and others added 8 commits April 9, 2024 15:00

Merge branch 'main' into feature/sharedmemorywithvectordb

1aa6c91

Refactor imports in user_usage_tracker.py

698ada9

Add pal dependency and remove unused test file

f0d3950

Fix bug in login functionality

e6e10f5

Remove faiss-cpu dependency

f6fb81f

Mock tests

9eb2fbc

Update poetry lock

dacae00

20001LastOrder self-requested a review April 11, 2024 02:00

20001LastOrder previously approved these changes Apr 11, 2024

View reviewed changes

oshoma previously approved these changes Apr 18, 2024

View reviewed changes

Merge branch 'main' into feature/sharedmemorywithvectordb

1186d9a

20001LastOrder dismissed stale reviews from oshoma and themself via 1186d9a April 18, 2024 19:56

20001LastOrder approved these changes Apr 18, 2024

View reviewed changes

20001LastOrder merged commit cb512c8 into Aggregate-Intellect:main Apr 18, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

create shared memory with vector db , #251

create shared memory with vector db , #251

Eyobyb commented Dec 6, 2023 •

edited

Loading

oshoma left a comment

oshoma commented Feb 7, 2024

20001LastOrder commented Feb 7, 2024 •

edited

Loading

oshoma commented Feb 7, 2024

oshoma commented Feb 20, 2024

Eyobyb commented Feb 21, 2024

oshoma left a comment

20001LastOrder left a comment

20001LastOrder commented Apr 3, 2024

20001LastOrder left a comment

20001LastOrder left a comment

20001LastOrder left a comment

20001LastOrder left a comment

create shared memory with vector db , #251

create shared memory with vector db , #251

Conversation

Eyobyb commented Dec 6, 2023 • edited Loading

oshoma left a comment

Choose a reason for hiding this comment

oshoma commented Feb 7, 2024

20001LastOrder commented Feb 7, 2024 • edited Loading

oshoma commented Feb 7, 2024

oshoma commented Feb 20, 2024

Eyobyb commented Feb 21, 2024

oshoma left a comment

Choose a reason for hiding this comment

20001LastOrder left a comment

Choose a reason for hiding this comment

20001LastOrder commented Apr 3, 2024

20001LastOrder left a comment

Choose a reason for hiding this comment

20001LastOrder left a comment

Choose a reason for hiding this comment

20001LastOrder left a comment

Choose a reason for hiding this comment

20001LastOrder left a comment

Choose a reason for hiding this comment

Eyobyb commented Dec 6, 2023 •

edited

Loading

20001LastOrder commented Feb 7, 2024 •

edited

Loading