-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create shared memory with vector db , #251
create shared memory with vector db , #251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments.
I don't really understand the purpose of this PR or the related issue, so @20001LastOrder should do a deeper review.
I just ran the tests again, this time in debug mode to see what GPT is doing with the request. I confirmed the file is passed through to GPT. However if you look at the response in the attached log file (view it in VS Code for colors) you'll see that GPT ignores the file content. Its response starts with, "How to summarize a file", and then it talks about how to summarize a PDF with AI. That part of the response looks like it comes from Google Search. Is that the expected behavior @20001LastOrder @Eyobyb ? See 2024-02-07-shared-memory-test.log On a separate note, the log also shows that Slack bolt app is running here, even though I am only running one specific test. I wonder how we can disable that. |
@oshoma The second question about Slack Bolt App: I think this is expected because you just ran |
src/tests/integration_tests/test_qa_agent_with_vectorSharedMemory.py
Outdated
Show resolved
Hide resolved
Got it, thanks. I guess just the act of collecting the tests runs |
Next steps: 1 .This still requires investigation:
|
I'm not sure where we discussed this before, but Percy confirmed that right now, we'll experience this issue because it always Google search tool as a qaAgent for any request, even if it already has the necessary information stored in its memory. |
change the agent to take user_type event , create a test that use qa agent to show sharedmemory with vector db fix pr review fix review issues create shared memory with vector db , change the agent to take user_type event , create a test that use qa agent to show sharedmemory with vector db fix issues raised on pr review
a498731
to
62017ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Some small change requests.
-
This PR has been open a long time. Please rebase on top of origin/main to pick up the latest changes from main.
src/tests/integration_tests/test_qa_agent_with_vectorSharedMemory.py
Outdated
Show resolved
Hide resolved
src/tests/integration_tests/test_qa_agent_with_vectorSharedMemory.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the comments below. Thanks!
I think everything else is ready for this PR, we need some comments/documentation in the .env_sample file for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the comments above
change the agent to take user_type event , create a test that use qa agent to show sharedmemory with vector db fix pr review fix review issues create shared memory with vector db , change the agent to take user_type event , create a test that use qa agent to show sharedmemory with vector db fix issues raised on pr review
d1daac6
to
78663a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I think I missed another comment above. Also, please rebase or merge the PR with the main branch so that the tests can be run.
change the agent to take user_type event , create a test that use qa agent to show sharedmemory with vector db fix pr review fix review issues create shared memory with vector db , change the agent to take user_type event , create a test that use qa agent to show sharedmemory with vector db fix issues raised on pr review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request (PR) has been created to improve file handling by implementing the use of a vector database. Within the test, the addition of a file to the vector database has been simulated. Ultimately, the QA agent utilizes the vector shared memory to incorporate the file added to the vector database as one source of context."
change the agent to take user_type event ,
create a test that use qa agent to show sharedmemory with vector db usage. also mimic what a scraped text with metadata should look like.
[resolves #235 ]