Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating some docs referencing the old docs URL #128

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Conversation

amirfz
Copy link
Contributor

@amirfz amirfz commented Aug 26, 2023

@20001LastOrder some of the files we have in /app hardcoded references to the library URL which is now moved to https://sherpa-ai.readthedocs.io/

I did a Find & Replace but I'm not sure what the relevance of those hardcoded URLs is. so can you review this PR, and make any changes necessary for those, and if everything looks good merge?

@ChenKua once this is merged, then we should update all the material related to the open book content in the vector database given the new URL above

Copy link
Collaborator

@20001LastOrder 20001LastOrder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@20001LastOrder 20001LastOrder merged commit c609452 into main Aug 27, 2023
@amirfz amirfz deleted the updating_docs branch August 29, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants