Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack App: Fail Safe in Conversation #23

Closed
20001LastOrder opened this issue Jul 11, 2023 · 5 comments
Closed

Slack App: Fail Safe in Conversation #23

20001LastOrder opened this issue Jul 11, 2023 · 5 comments
Assignees

Comments

@20001LastOrder
Copy link
Collaborator

20001LastOrder commented Jul 11, 2023

Currently, if there are any issues happening when the bot is searching for a response to the user's input, it will just fail silently and raise HTTP 500 Internal Server Error. This corresponds to no response in the Slack thread, making it hard to distinguish if an error happens or if the bot is still executing.

Expected output: When any issues happen for the bot, it should respond something like "An error has happened" to notify the user. More specifically, we can categorize the errors into issues in the code, timeout from OpenAI API, or database errors.

assignee: Yujing

@YujingYang666777
Copy link
Contributor

Description:
when the bot is searching for a response to the user's input, it will just fail silently and raise HTTP 500 Internal Server Error. This corresponds to no response in the Slack thread, making it hard to distinguish if an error happens or if the bot is still executing.

Steps to Reproduce:

Actual Results:

  • No response

Expected Results:

  • Print the error message. For example: timeout error

Additional Information:
N/A

Reproducibility:

  • Mention whether the issue is reproducible intermittently.

Possible Solutions:

Related Issues:
N/A

Steps Taken So Far:
N/A

Environment:
N/A

saminegash added a commit that referenced this issue Aug 16, 2023
Solve #38 none command and #23 error handeling
@amirfz
Copy link
Contributor

amirfz commented Aug 22, 2023

ah this is the error handling one right? @20001LastOrder @Eyobyb @YujingYang666777

@YujingYang666777
Copy link
Contributor

resolved in pull request #63

@amirfz
Copy link
Contributor

amirfz commented Aug 22, 2023

we need an app level catch-all error handler (for slack) that says something like: "something went wrong! please tag amir feizpour on this thread"

@amirfz
Copy link
Contributor

amirfz commented Sep 7, 2023

tackled in #141

@amirfz amirfz closed this as completed Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants