-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change video info to be generator #39
Change video info to be generator #39
Conversation
Updated test cases.
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 2.01%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
follow https://cbea.ms/git-commit/ for commit guidelines
you should put the title as Chnage video info to be generator
with no period at the end of the title.
tests/test_util.py
Outdated
@@ -1,7 +1,7 @@ | |||
import datetime | |||
import os | |||
import unittest | |||
|
|||
import types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
follow PEP8 for import order https://peps.python.org/pep-0008/#imports
this should be
import datetime
import os
import types
import unittest
present tense in the commit message title is preferred in a lot of projects. |
I have updated the commit message , again thanks for the PR |
@BismeetSingh one more thing you should change the doc and README to reflect these changes |
Changed video info to be generator and updated test cases for #38 .