Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change video info to be generator #39

Merged

Conversation

BismeetSingh
Copy link
Contributor

Changed video info to be generator and updated test cases for #38 .

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 15, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 2.01%.

Quality metrics Before After Change
Complexity 0.42 ⭐ 0.29 ⭐ -0.13 👍
Method Length 21.38 ⭐ 21.62 ⭐ 0.24 👎
Working memory 4.05 ⭐ 3.47 ⭐ -0.58 👍
Quality 93.54% 95.55% 2.01% 👍
Other metrics Before After Change
Lines 30 26 -4
Changed files Quality Before Quality After Quality Change
pyytdata/pyytdata.py 89.87% ⭐ 93.39% ⭐ 3.52% 👍
tests/test_util.py 97.61% ⭐ 97.06% ⭐ -0.55% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Copy link
Owner

@Agent-Hellboy Agent-Hellboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow https://cbea.ms/git-commit/ for commit guidelines

you should put the title as Chnage video info to be generator with no period at the end of the title.

@@ -1,7 +1,7 @@
import datetime
import os
import unittest

import types
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow PEP8 for import order https://peps.python.org/pep-0008/#imports

this should be
import datetime
import os
import types
import unittest

@BismeetSingh BismeetSingh changed the title Changed video info to be generator. Changed video info to be generator Oct 15, 2022
@Agent-Hellboy
Copy link
Owner

present tense in the commit message title is preferred in a lot of projects.

@Agent-Hellboy Agent-Hellboy changed the title Changed video info to be generator Change video info to be generator Oct 15, 2022
@Agent-Hellboy
Copy link
Owner

Agent-Hellboy commented Oct 15, 2022

I have updated the commit message , again thanks for the PR

@Agent-Hellboy
Copy link
Owner

Agent-Hellboy commented Oct 15, 2022

@BismeetSingh one more thing you should change the doc and README to reflect these changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants