Skip to content

Commit

Permalink
feat: avm/res/storage/storage-account Add additional built-in roles…
Browse files Browse the repository at this point in the history
… to Storage Module (Azure#2736)

## Description

Add additional Builtin Roles to the Storage module
Closes Azure#2698 

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.storage.storage-account](https://github.com/ktremain/bicep-registry-modules/actions/workflows/avm.res.storage.storage-account.yml/badge.svg?branch=addBuiltInRoles)](https://github.com/ktremain/bicep-registry-modules/actions/workflows/avm.res.storage.storage-account.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [X] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [x] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
  • Loading branch information
ktremain authored Aug 13, 2024
1 parent 72b4d0c commit 4a59f7c
Show file tree
Hide file tree
Showing 3 changed files with 41 additions and 31 deletions.
8 changes: 8 additions & 0 deletions avm/res/storage/storage-account/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,14 @@ var builtInRoleNames = {
'Microsoft.Authorization/roleDefinitions',
'db58b8e5-c6ad-4a2a-8342-4190687cbf4a'
)
'Storage File Data Privileged Contributor': subscriptionResourceId(
'Microsoft.Authorization/roleDefinitions',
'69566ab7-960f-475b-8e7c-b3118f30c6bd'
)
'Storage File Data Privileged Reader': subscriptionResourceId(
'Microsoft.Authorization/roleDefinitions',
'b8eda974-7b85-4f76-af95-65846b26df6d'
)
'Storage File Data SMB Share Contributor': subscriptionResourceId(
'Microsoft.Authorization/roleDefinitions',
'0c867c2a-1d8c-454a-a3db-ab2ea1bdc8bb'
Expand Down
54 changes: 28 additions & 26 deletions avm/res/storage/storage-account/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "7446053749806505838"
"version": "0.28.1.47646",
"templateHash": "18243608851255445298"
},
"name": "Storage Accounts",
"description": "This module deploys a Storage Account.",
Expand Down Expand Up @@ -872,6 +872,8 @@
"Storage Blob Data Owner": "[subscriptionResourceId('Microsoft.Authorization/roleDefinitions', 'b7e6dc6d-f1e8-4753-8033-0f276bb0955b')]",
"Storage Blob Data Reader": "[subscriptionResourceId('Microsoft.Authorization/roleDefinitions', '2a2b9908-6ea1-4ae2-8e65-a410df84e7d1')]",
"Storage Blob Delegator": "[subscriptionResourceId('Microsoft.Authorization/roleDefinitions', 'db58b8e5-c6ad-4a2a-8342-4190687cbf4a')]",
"Storage File Data Privileged Contributor": "[subscriptionResourceId('Microsoft.Authorization/roleDefinitions', '69566ab7-960f-475b-8e7c-b3118f30c6bd')]",
"Storage File Data Privileged Reader": "[subscriptionResourceId('Microsoft.Authorization/roleDefinitions', 'b8eda974-7b85-4f76-af95-65846b26df6d')]",
"Storage File Data SMB Share Contributor": "[subscriptionResourceId('Microsoft.Authorization/roleDefinitions', '0c867c2a-1d8c-454a-a3db-ab2ea1bdc8bb')]",
"Storage File Data SMB Share Elevated Contributor": "[subscriptionResourceId('Microsoft.Authorization/roleDefinitions', 'a7264617-510b-434b-a828-9731dc254ea7')]",
"Storage File Data SMB Share Reader": "[subscriptionResourceId('Microsoft.Authorization/roleDefinitions', 'aba4ae5f-2193-4029-9191-0cb91df5e314')]",
Expand Down Expand Up @@ -1757,8 +1759,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "11289787713365096902"
"version": "0.28.1.47646",
"templateHash": "9473195527943694039"
},
"name": "Storage Account Management Policies",
"description": "This module deploys a Storage Account Management Policy.",
Expand Down Expand Up @@ -1867,8 +1869,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "18130658711251621530"
"version": "0.28.1.47646",
"templateHash": "14968464858285923305"
},
"name": "Storage Account Local Users",
"description": "This module deploys a Storage Account Local User, which is used for SFTP authentication.",
Expand Down Expand Up @@ -2085,8 +2087,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "6152214765227449988"
"version": "0.28.1.47646",
"templateHash": "15628074782479790529"
},
"name": "Storage Account blob Services",
"description": "This module deploys a Storage Account Blob Service.",
Expand Down Expand Up @@ -2483,8 +2485,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "2376441074312126168"
"version": "0.28.1.47646",
"templateHash": "9799310010232033446"
},
"name": "Storage Account Blob Containers",
"description": "This module deploys a Storage Account Blob Container.",
Expand Down Expand Up @@ -2766,8 +2768,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "7245741358008626948"
"version": "0.28.1.47646",
"templateHash": "2543276032744560941"
},
"name": "Storage Account Blob Container Immutability Policies",
"description": "This module deploys a Storage Account Blob Container Immutability Policy.",
Expand Down Expand Up @@ -2945,8 +2947,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "11112322068652007329"
"version": "0.28.1.47646",
"templateHash": "4779228382784039223"
},
"name": "Storage Account File Share Services",
"description": "This module deploys a Storage Account File Share Service.",
Expand Down Expand Up @@ -3226,8 +3228,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "7774942141784896900"
"version": "0.28.1.47646",
"templateHash": "15870640065752688325"
},
"name": "Storage Account File Shares",
"description": "This module deploys a Storage Account File Share.",
Expand Down Expand Up @@ -3433,8 +3435,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "17818484349715313082"
"version": "0.28.1.47646",
"templateHash": "5083161177149847899"
}
},
"parameters": {
Expand Down Expand Up @@ -3709,8 +3711,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "11962188257977966881"
"version": "0.28.1.47646",
"templateHash": "575766518880293249"
},
"name": "Storage Account Queue Services",
"description": "This module deploys a Storage Account Queue Service.",
Expand Down Expand Up @@ -3954,8 +3956,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "18160215842105253661"
"version": "0.28.1.47646",
"templateHash": "359886569394059505"
},
"name": "Storage Account Queues",
"description": "This module deploys a Storage Account Queue.",
Expand Down Expand Up @@ -4225,8 +4227,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "11825608650296439803"
"version": "0.28.1.47646",
"templateHash": "4010826129148024553"
},
"name": "Storage Account Table Services",
"description": "This module deploys a Storage Account Table Service.",
Expand Down Expand Up @@ -4467,8 +4469,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.29.47.4906",
"templateHash": "16189309416113928106"
"version": "0.28.1.47646",
"templateHash": "16147754905914987523"
},
"name": "Storage Account Table",
"description": "This module deploys a Storage Account Table.",
Expand Down
10 changes: 5 additions & 5 deletions avm/res/storage/storage-account/version.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.11",
"pathFilters": [
"./main.json"
]
"$schema": "https://aka.ms/bicep-registry-module-version-file-schema#",
"version": "0.12",
"pathFilters": [
"./main.json"
]
}

0 comments on commit 4a59f7c

Please sign in to comment.