Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review page UI Changed!! #166 #200

Merged
merged 24 commits into from
Oct 29, 2023
Merged

review page UI Changed!! #166 #200

merged 24 commits into from
Oct 29, 2023

Conversation

ancy0
Copy link
Contributor

@ancy0 ancy0 commented Oct 29, 2023

Describe changes

  • Separate review items into different files.
  • Change icon and progress color based on status.
  • Add to notification when "need authority" but also when false
  • Modify text

check list

  • Check to apply icon and progress color according to repo status.
    리뷰 결과에 따라서 아이콘 및 progress 의 색상 적용(변경) 되었는지 확인
  • If null or false, check that it is properly added to the list of notifications.
    null(need authority) 이나 false 인경우 notification의 리스트에 제대로 추가되어 나오는지 확인
  • Check the chart for correct reflection of the results.
    차트에 결과가 제대로 반영되어 표시 되는지 확인
  • Check that the changed text is appropriate
    변경된 텍스트가 적절한지 확인
  • For need authority, check if it is associated with notification even if there is no hover effect.
    need authority의 경우 hover 효과가 없더라도 notification과 연관지어지는지 확인

Issue number or link

#166

Types of changes

What is the type of code change?
Put an x in the boxes that apply

  • Bugfix (changes that resolve errors)
  • New feature (changes which adds functionality)
  • Breaking change (big changes that affect existing functionality)
  • Documentation Update

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the "README.md"
  • My code follows the style guidelines of this project
  • My changes generate no new warnings
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation
  • Any dependent changes have been merged and published in downstream modules

Further comments

Please let me know if there's anything else to explain

@ancy0 ancy0 linked an issue Oct 29, 2023 that may be closed by this pull request
2 tasks
@ymw0407 ymw0407 self-requested a review October 29, 2023 11:50
@ymw0407 ymw0407 changed the title tory547392Feature/166 review page UI Changed!! #166 Oct 29, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@ymw0407 ymw0407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Good!

@ancy0 ancy0 merged commit c295469 into main Oct 29, 2023
6 checks passed
@ancy0 ancy0 deleted the feature/166 branch October 29, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 [REQUEST] - Modify 'Open-Source operational review' page ui
2 participants