Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conditional cardholdername logic #1137

Merged

Conversation

zenit2001
Copy link
Contributor

@zenit2001 zenit2001 commented Aug 12, 2024

Summary

Describe the changes proposed in this pull request:

  • What is the motivation for this change?
    After implementing new visa compliance rules, the conditional cardholder name logic is not anymore required, as we set the hasHolderName and holderNameRequired to true by default in the card config.
  • What existing problem does this pull request solve?
    Removes the metadata fields and logic related to conditional cardholder name boolean.

Tested scenarios

Description of tested scenarios:

  • Card payments
  • Stored card payments

Fixed issue: SFI-872

Copy link

sonarcloud bot commented Aug 12, 2024

@zenit2001 zenit2001 marked this pull request as ready for review August 12, 2024 07:47
@shanikantsingh shanikantsingh merged commit 6447a6f into develop Aug 12, 2024
19 of 20 checks passed
@shanikantsingh shanikantsingh added the excluded Will be ignored in the release notes label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
excluded Will be ignored in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants