PayPal Express in Cart and Mini-Cart page #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: adding the possibility to enable/disable paypal ecs from BM * chore: linting * fix: fixing klarna e2e test
* feat: paypalUpdateOrder endpoint * test: unit tests and jsdoc annotations * feat: paypal update order * feat(SFI-696): show paypal express if enabled in BM * chore(SFI-696): add sonar properties file * refactor(SFI-696): function to create redirectUrl * feat(SFI-696): add stacktrace for error and fatal logs * chore(SFI-696): exclude e2e tests from sonar * fix(SFI-696): clear session.privacy data for paypal express * chore(SFI-696): undo changes to cartridges * fix(SFI-696): zero-auth flow
* feat(SFI-790): new template for checkout review button * feat(SFI-789): handle payments details call from checkout review page * feat(SFI-789): create basket view data on express review page * feat(SFI-789): create basket view data on express review page
zenit2001
requested review from
maassenbas,
amihajlovski and
shanikantsingh
as code owners
dcardos
reviewed
Jul 19, 2024
src/cartridges/app_adyen_SFRA/cartridge/client/default/js/paypalExpress.js
Show resolved
Hide resolved
src/cartridges/app_adyen_SFRA/cartridge/client/default/js/paypalExpress.js
Show resolved
Hide resolved
src/cartridges/app_adyen_SFRA/cartridge/client/default/js/paypalExpress.js
Show resolved
Hide resolved
...t_adyen_SFRA/cartridge/adyen/scripts/expressPayments/paypal/makeExpressPaymentDetailsCall.js
Show resolved
Hide resolved
dcardos
previously approved these changes
Jul 19, 2024
|
dcardos
approved these changes
Jul 23, 2024
amihajlovski
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the PayPal express as a payment method in SFCC cartridge, including the possibility to use the flow with order review page and without order review page.
Enablement of PayPal Express
Tested scenarios
Description of tested scenarios:
Fixed issue: SFI-42