Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering the confirm form if order is already processed #1052

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

zenit2001
Copy link
Contributor

Summary

Describe the changes proposed in this pull request:

  • What is the motivation for this change?
    Shopper being returned to empty card page if Return to shop button inside Online Banking PL simulator was being used.
    This was happening because order was already processed, and shopper tries to return back to the website (not by waiting the redirect to finish, but by pressing the back button or using Return to shop button inside the simulators), and the logic triggered was landing him to cart page.
  • What existing problem does this pull request solve?
    It returns the shopper to the confirmation page instead of returning the shopper to an empty card page.

Tested scenarios

Description of tested scenarios:

  • Online Banking PL ( Using automatic redirect and by pressing the Return button inside simulator)
  • iDeal
  • Cards

Fixed issue: SFI-621

Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@zenit2001 zenit2001 added the fix Fixes a bug label Feb 22, 2024
@zenit2001 zenit2001 marked this pull request as ready for review February 22, 2024 12:38
@zenit2001 zenit2001 merged commit ef352d4 into develop Feb 26, 2024
15 checks passed
@zenit2001 zenit2001 deleted the bugfix/SFI-621-online_bankingPL_returnUrl branch February 26, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants