Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving the issue of broken Order view page after installing express checkout #109

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

khushboo-singhvi
Copy link
Contributor

Summary

A new payment method group adyen-express-payment-method was introduced for adyen_paypal_express payment method, but this group wasn't defined in the payment.xml and therefore it was failing to retrieve the label information when it was trying to access $this->_getOptions()->label failing in successful displaying the order details page.

Tested scenarios

Fixed issue:

@khushboo-singhvi khushboo-singhvi requested a review from a team as a code owner September 16, 2024 12:57
etc/payment.xml Outdated Show resolved Hide resolved
Updating date and file signatures

Co-authored-by: Can Demiralp <[email protected]>
etc/payment.xml Outdated Show resolved Hide resolved
Removing unused group id
Copy link

sonarcloud bot commented Sep 16, 2024

@khushboo-singhvi khushboo-singhvi merged commit 1ecd08d into main Sep 16, 2024
7 checks passed
@khushboo-singhvi khushboo-singhvi deleted the ECP-9436 branch September 16, 2024 13:45
@khushboo-singhvi khushboo-singhvi mentioned this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants