-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add props 'showPages' and 'collectInformation' to GetOnboardingUrlRequest #626
add props 'showPages' and 'collectInformation' to GetOnboardingUrlRequest #626
Conversation
See https://docs.adyen.com/api-explorer/#/Hop/v6/post/getOnboardingUrl for docs on 'showPages' and 'collectInformation' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @fipp,
Thank you for submitting this PR!
All looks well, apart from the toString functions in the new models.
Please look at the suggestions I provided. This follows the format of all other models in the library.
I very much appreciate your contribution, and apologies for the slow response!
Kind regards,
Wouter
Adyen
src/main/java/com/adyen/model/hop/OnboardingCollectInformation.java
Outdated
Show resolved
Hide resolved
src/main/java/com/adyen/model/hop/OnboardingCollectInformation.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Wouter Boereboom <[email protected]>
Co-authored-by: Wouter Boereboom <[email protected]>
Ah I see! I accepted your commits and added one myself for the rest. Does it seem correct now? |
Description
Interacting with a Adyen business developer Robert Ruppi, we (FINNnoECOM) got forwarded extra config flags "showPages" and "collectInformation" to send to the create hosted onbarding page url endpoint, to tailor what is shown and what is collected. Currently we call the API directly without using the SDK, but it would be nice to get this into the SDK as well.
Tested scenarios
I built the SDK as 17.0.1-SNAPSHOT and included it in our repo. and tested it towards the test environment where I successfully got back an hosted onboarding page url. Not tested towards the live environment as we don't have set up that environment yet. (Working on it though).