Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add props 'showPages' and 'collectInformation' to GetOnboardingUrlRequest #626

Merged
merged 7 commits into from
Oct 29, 2021

Conversation

fipp
Copy link
Contributor

@fipp fipp commented Sep 29, 2021

Description
Interacting with a Adyen business developer Robert Ruppi, we (FINNnoECOM) got forwarded extra config flags "showPages" and "collectInformation" to send to the create hosted onbarding page url endpoint, to tailor what is shown and what is collected. Currently we call the API directly without using the SDK, but it would be nice to get this into the SDK as well.

Tested scenarios
I built the SDK as 17.0.1-SNAPSHOT and included it in our repo. and tested it towards the test environment where I successfully got back an hosted onboarding page url. Not tested towards the live environment as we don't have set up that environment yet. (Working on it though).

@coveralls
Copy link

coveralls commented Sep 29, 2021

Coverage Status

Coverage increased (+0.02%) to 29.344% when pulling 852aecb on fipp:add-hop-showpages-collectinformation into cf87589 on Adyen:develop.

@fipp
Copy link
Contributor Author

fipp commented Oct 12, 2021

See https://docs.adyen.com/api-explorer/#/Hop/v6/post/getOnboardingUrl for docs on 'showPages' and 'collectInformation'

@fipp fipp requested a review from Morerice as a code owner October 12, 2021 10:54
AlexandrosMor
AlexandrosMor previously approved these changes Oct 18, 2021
Copy link
Contributor

@wboereboom wboereboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @fipp,

Thank you for submitting this PR!
All looks well, apart from the toString functions in the new models.
Please look at the suggestions I provided. This follows the format of all other models in the library.

I very much appreciate your contribution, and apologies for the slow response!

Kind regards,
Wouter
Adyen

@fipp
Copy link
Contributor Author

fipp commented Oct 29, 2021

Thank you for submitting this PR! All looks well, apart from the toString functions in the new models. Please look at the suggestions I provided. This follows the format of all other models in the library.

I very much appreciate your contribution, and apologies for the slow response!

Ah I see! I accepted your commits and added one myself for the rest. Does it seem correct now?

@fipp fipp requested a review from wboereboom October 29, 2021 11:36
@wboereboom wboereboom merged commit 4673841 into Adyen:develop Oct 29, 2021
@wboereboom wboereboom mentioned this pull request Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants