Improving the library compatibility. #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recovering compatibility with Android 6 M API level 23 and earlier versions. java.util.Optional was added in API level 24 (Android 7 N). https://developer.android.com/reference/java/util/Optional
OscarTF
requested review from
abhilash-adyen,
Aleffio,
andrei-dediu,
martinsrenato and
rkewlani
as code owners
saquibsayyad
previously approved these changes
Jul 1, 2021
saquibsayyad
approved these changes
Jul 1, 2021
|
Up. We started implementing the adyen java api library and we are currently stuck because of the use of Optional. The proposed change does the trick and is pretty insignificant code wise. |
Aleffio
approved these changes
Aug 13, 2021
AlexandrosMor
approved these changes
Aug 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recovering compatibility with Android 6 M API level 23 and earlier versions.
java.util.Optional was added in API level 24 (Android 7 N).
https://developer.android.com/reference/java/util/Optional