Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Region class with valid regions plus endpoint mappings for terminal api live #1407

Merged
merged 40 commits into from
Dec 31, 2024

Conversation

DjoykeAbyah
Copy link
Member

Adjusted Region class to define region constants and their associated Terminal API endpoint mappings.

Added a RegionTest class to validate:

The list of valid regions (VALID_REGIONS) matches expected values.
The endpoint mappings (TERMINAL_API_ENDPOINTS_MAPPING) are consistent with the provided regions.
Adjusted the Client class to include public static endpoint constants that the Region class references.

@DjoykeAbyah DjoykeAbyah requested a review from a team as a code owner December 17, 2024 08:51
Copy link
Contributor

@Kwok-he-Chu Kwok-he-Chu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just some minor nitpicks

src/test/java/com/adyen/ClientTest.java Outdated Show resolved Hide resolved
src/test/java/com/adyen/ClientTest.java Outdated Show resolved Hide resolved
src/test/java/com/adyen/RegionTest.java Outdated Show resolved Hide resolved
src/test/java/com/adyen/RegionTest.java Outdated Show resolved Hide resolved
src/test/java/com/adyen/ClientTest.java Outdated Show resolved Hide resolved
src/main/java/com/adyen/enums/Region.java Show resolved Hide resolved
src/main/java/com/adyen/Client.java Outdated Show resolved Hide resolved
Kwok-he-Chu
Kwok-he-Chu previously approved these changes Dec 31, 2024
Copy link
Contributor

@Kwok-he-Chu Kwok-he-Chu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@DjoykeAbyah DjoykeAbyah merged commit 4b1d5b4 into main Dec 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants