-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Region class with valid regions plus endpoint mappings for terminal api live #1407
Conversation
…red getCloudEndpoint test in Client.java and ClientTest.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, just some minor nitpicks
removed comments in tests
Add indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!
Quality Gate passedIssues Measures |
Adjusted Region class to define region constants and their associated Terminal API endpoint mappings.
Added a RegionTest class to validate:
The list of valid regions (VALID_REGIONS) matches expected values.
The endpoint mappings (TERMINAL_API_ENDPOINTS_MAPPING) are consistent with the provided regions.
Adjusted the Client class to include public static endpoint constants that the Region class references.