Replace apache.commons Base64 with jdk Base64 #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jillingk
reviewed
Oct 24, 2023
Aleffio
reviewed
Oct 24, 2023
michaelpaul
approved these changes
Oct 26, 2023
Aleffio
approved these changes
Oct 27, 2023
jillingk
approved these changes
Oct 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
java.util.Base64is more performant thanorg.apache.commons.codec.binary.Base64.We already use
java.util.Base64in some of the Unit tests, but we still useorg.apache.commons.codec.binary.Base64in the code.Replace the apache commons Base64 with the ones from the jdk.
Tested scenarios
All tests are passing