Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COIOS-802: Identify native redirect flow (v5) #1879

Draft
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

nauaros
Copy link
Contributor

@nauaros nauaros commented Oct 25, 2024

Summary

This development enables us to differentiate between regular and native redirects. To handle cases where native redirects fail (indicated by nativeRedirectData being nil), it's essential to track the originating flow type of each redirect.

Motivation

Native redirect flows can occasionally fail if nativeRedirectData is nil within the action object. Currently, we handle this by discarding the native redirect (checking if nativeRedirectData is nil), and defaulting to a "direct issuer flow" using a /details call.

To avoid the additional steps of the "direct issuer flow," we can address this issue on the backend. By identifying the native redirect flow, we can still retrieve the native redirect result directly.

Release notes

  • TBD

Ticket

COIOS-802

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['new', 'changed', 'fixed', 'removed', 'deprecated', 'chore', 'improvement']

@nauaros nauaros added the new a pull request that adds a new feature label Oct 25, 2024
github-actions[bot]
github-actions bot previously approved these changes Oct 25, 2024
@nauaros nauaros marked this pull request as draft October 25, 2024 15:03
github-actions[bot]
github-actions bot previously approved these changes Oct 28, 2024
github-actions[bot]
github-actions bot previously approved these changes Oct 28, 2024
github-actions[bot]
github-actions bot previously approved these changes Oct 29, 2024
github-actions[bot]
github-actions bot previously approved these changes Oct 29, 2024
github-actions[bot]
github-actions bot previously approved these changes Oct 29, 2024
github-actions[bot]
github-actions bot previously approved these changes Oct 29, 2024
AdyenActions/Actions/RedirectAction.swift Outdated Show resolved Hide resolved
AdyenActions/Actions/RedirectAction.swift Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot previously approved these changes Oct 31, 2024
github-actions[bot]
github-actions bot previously approved these changes Oct 31, 2024
goergisn
goergisn previously approved these changes Oct 31, 2024
@nauaros nauaros dismissed stale reviews from goergisn and github-actions[bot] via 63c1355 November 1, 2024 15:06
github-actions[bot]
github-actions bot previously approved these changes Nov 1, 2024
@nauaros nauaros self-assigned this Nov 5, 2024
@goergisn goergisn self-requested a review November 14, 2024 15:15
Copy link
Contributor

👀 2 public changes detected

Comparing COIOS-802_identify_native_redirect_flow to develop


AdyenActions

RedirectAction

❇️ Added

public enum RedirectType: Swift.String, Swift.Decodable, Swift.Equatable, Swift.Hashable, Swift.RawRepresentable
{
  case redirect
  case nativeRedirect
  public init(from decoder: any Swift.Decoder) throws
  public init?(rawValue: Swift.String)
  public typealias RawValue = Swift.String
  public var rawValue: Swift.String { get }
}

🔀 Changed

// From
public init(url: Foundation.URL, paymentData: Swift.String?, nativeRedirectData: Swift.String? = nil)

// To
public init(url: Foundation.URL, paymentData: Swift.String?, type: AdyenActions.RedirectAction.RedirectType = .redirect, nativeRedirectData: Swift.String? = nil)

/**
Changes:
- Added parameter `type: AdyenActions.RedirectAction.RedirectType = .redirect`
*/

Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay

Copy link

sonarcloud bot commented Nov 25, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new a pull request that adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants