Skip to content

Commit

Permalink
switching to iOS 18 for pr_scan
Browse files Browse the repository at this point in the history
  • Loading branch information
Alex Guretzki committed Dec 2, 2024
1 parent d58ebe3 commit 7abd316
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/pr_scan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
build:
env:
sonarToken: ${{ secrets.SONAR_TOKEN }}
destination: "name=iPhone 15 Pro,OS=17.2"
destination: "name=iPhone 16 Pro,OS=18.0"
project: "Adyen.xcodeproj"
params: "-derivedDataPath ./DerivedData -skipPackagePluginValidation"
runs-on: macos-14-xlarge # Apple Silicon Runner
runs-on: macos-15-xlarge # Apple Silicon Runner

steps:
- uses: actions/checkout@v4
Expand All @@ -32,7 +32,7 @@ jobs:
- name: Select latest Xcode
uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: '15.1'
xcode-version: '16.0'

- name: 🛠️ Install Tools
run: |
Expand Down Expand Up @@ -71,7 +71,7 @@ jobs:
-enableCodeCoverage YES \
-resultBundlePath "${resultPath}" \
${params} \
-destination "name=iPhone 15 Pro,OS=17.2" -destination "name=iPad (10th generation),OS=17.2" | xcpretty --utf --color && exit ${PIPESTATUS[0]}
-destination "name=iPhone 16 Pro,OS=18.0" -destination "name=iPad (10th generation),OS=18.0" | xcpretty --utf --color && exit ${PIPESTATUS[0]}
env:
params: '${{env.params}}'
scheme: 'SnapshotTests'
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/regenerate-snapshots.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:

jobs:
Generate:
runs-on: macos-14-xlarge
runs-on: macos-15-xlarge

steps:
- uses: actions/checkout@v4
Expand All @@ -15,14 +15,14 @@ jobs:
- name: 🔨 Select Xcode
uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: '15.1'
xcode-version: '16.0'

- name: 🧹 Clear existing Snapshots
run: |
find ./Tests/SnapshotTests -name "__Snapshots__" -exec rm -rf {} +
- name: 📸 Generate Snapshots
run: |
xcodebuild test -project "${project}" -scheme "${scheme}" ${params} -destination "name=iPhone 15 Pro,OS=17.2" -destination "name=iPad (10th generation),OS=17.2" | xcpretty --utf --color
xcodebuild test -project "${project}" -scheme "${scheme}" ${params} -destination "name=iPhone 16 Pro,OS=18.0" -destination "name=iPad (10th generation),OS=18.0" | xcpretty --utf --color && exit ${PIPESTATUS[0]}
env:
project: 'Adyen.xcodeproj'
params: '-skipPackagePluginValidation'
Expand Down

0 comments on commit 7abd316

Please sign in to comment.