Run integration tests only before releases (#257)

* Tagging integration tests * Use 'unit' tag on regular PR's * Mocking tests * Fix conflicts * Mock response function * Renaming Balance Platform tests
Adyen · Nov 3, 2023 · 81e5da9 · 81e5da9
1 parent 5803e7f
commit 81e5da9
Show file tree

Hide file tree

Showing 27 changed files with 1,056 additions and 275 deletions.
diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
@@ -9,22 +9,18 @@ jobs:
     name: Build & Verify
     runs-on: ubuntu-latest
     steps:
-
     - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4
-
     - uses: actions/setup-go@v4
       with:
         go-version: 1.13
-
     - name: Get dependencies
       run: go get -v -t -d ./...
-
     - name: Build
       run: go build -v .
-
     - name: Test
-      run: go test ./...
+      run: go test -v ./... -tags $GO_TEST_TAGS
       env:
+        GO_TEST_TAGS: ${{ github.ref == 'refs/heads/main' && 'integration' || 'unit' }}
         ADYEN_API_KEY: ${{ secrets.ADYEN_API_KEY }}
         ADYEN_MERCHANT: ${{ secrets.ADYEN_MERCHANT }}
         ADYEN_PASSWORD: ${{ secrets.ADYEN_PASSWORD }}

diff --git a/src/adyen/api_test.go b/src/adyen/api_test.go
@@ -1,3 +1,6 @@
+//go:build integration
+// +build integration
+
 package adyen
 
 import (

diff --git a/tests/api_modifications_test.go b/tests/api_modifications_test.go
@@ -1,3 +1,6 @@
+//go:build integration
+// +build integration
+
 package tests
 
 import (

diff --git a/...anceplatform_acs_webhooks_handler_test.go → tests/balanceplatform/acswebhook_test.go b/...anceplatform_acs_webhooks_handler_test.go → tests/balanceplatform/acswebhook_test.go
@@ -1,4 +1,4 @@
-package tests
+package balanceplatform
 
 import (
 	"github.com/adyen/adyen-go-api-library/v8/src/acswebhook"
@@ -7,7 +7,7 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-func Test_BalancePlatform_Acs_Webhooks_HandleRequest(t *testing.T) {
+func TestHandleAuthenticationNotificationRequest(t *testing.T) {
 	t.Run("on balancePlatform.authentication.created", func(t *testing.T) {
 		notificationJson := `{
           "data": {

diff --git a/...rm_configuration_webhooks_handler_test.go → ...anceplatform/configurationwebhook_test.go b/...rm_configuration_webhooks_handler_test.go → ...anceplatform/configurationwebhook_test.go
@@ -1,4 +1,4 @@
-package tests
+package balanceplatform
 
 import (
 	"testing"
@@ -9,8 +9,7 @@ import (
 	"github.com/adyen/adyen-go-api-library/v8/src/configurationwebhook"
 )
 
-func Test_BalancePlatform_Configuration_Webhooks_HandleRequest(t *testing.T) {
-
+func TestHandleAccountHolderNotificationRequest(t *testing.T) {
 	t.Run("should return accountHolder created success", func(t *testing.T) {
 		notificationJson := `{
 			"data": {

diff --git a/...eplatform_report_webhooks_handler_test.go → tests/balanceplatform/reportwebhook_test.go b/...eplatform_report_webhooks_handler_test.go → tests/balanceplatform/reportwebhook_test.go
@@ -1,4 +1,4 @@
-package tests
+package balanceplatform
 
 import (
 	"testing"
@@ -8,8 +8,7 @@ import (
 	"github.com/adyen/adyen-go-api-library/v8/src/reportwebhook"
 )
 
-func Test_BalancePlatform_Report_Webhooks_HandleRequest(t *testing.T) {
-
+func TestHandleReportNotificationRequest(t *testing.T) {
 	t.Run("should return report created success", func(t *testing.T) {
 		notificationJson := `{
 			"data": {

diff --git a/...latform_transfer_webhooks_handler_test.go → ...s/balanceplatform/transferwebhook_test.go b/...latform_transfer_webhooks_handler_test.go → ...s/balanceplatform/transferwebhook_test.go
@@ -1,4 +1,4 @@
-package tests
+package balanceplatform
 
 import (
 	"testing"
@@ -8,8 +8,7 @@ import (
 	"github.com/adyen/adyen-go-api-library/v8/src/transferwebhook"
 )
 
-func Test_BalancePlatform_Transfer_Webhooks_HandleRequest(t *testing.T) {
-
+func TestHandleTransferNotificationRequest(t *testing.T) {
 	t.Run("should return transfer success", func(t *testing.T) {
 		notificationJson := `{
 			"data": {

diff --git a/tests/balanceplatform_test.go → tests/balanceplatform/unit_test.go b/tests/balanceplatform_test.go → tests/balanceplatform/unit_test.go
@@ -1,11 +1,12 @@
-package tests
+package balanceplatform
 
 import (
 	"context"
 	"errors"
 	"github.com/adyen/adyen-go-api-library/v8/src/adyen"
 	"github.com/adyen/adyen-go-api-library/v8/src/balanceplatform"
 	"github.com/adyen/adyen-go-api-library/v8/src/common"
+	"github.com/adyen/adyen-go-api-library/v8/tests"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	"io"
@@ -15,7 +16,7 @@ import (
 	"testing"
 )
 
-func Test_BalancePlatform(t *testing.T) {
+func TestBalancePlatform(t *testing.T) {
 	client := adyen.NewClient(&common.Config{
 		ApiKey:      "YOUR_ADYEN_API_KEY",
 		Environment: "TEST",
@@ -24,19 +25,16 @@ func Test_BalancePlatform(t *testing.T) {
 	service := client.BalancePlatform()
 
 	mux := http.NewServeMux()
-	// Success case
-	mux.HandleFunc("/accountHolders/123", func(w http.ResponseWriter, r *http.Request) {
-		assert.Contains(t, [2]string{"GET", "PATCH"}, r.Method)
-		w.Header().Set("Content-Type", "application/json")
-		file, _ := os.Open("fixtures/account_holder.json")
-		io.Copy(w, file)
-	})
+	mockResponse := tests.MockResponse(t, mux)
+
+	// Success cases
+	mockResponse(http.StatusOK, "GET PATCH", "/accountHolders/123", "account_holder.json")
 	mux.HandleFunc("/accountHolders/123/balanceAccounts", func(w http.ResponseWriter, r *http.Request) {
 		require.Equal(t, "GET", r.Method)
 		assert.Equal(t, "5", r.URL.Query().Get("limit"))
 		assert.Equal(t, "42", r.URL.Query().Get("offset"))
 		w.Header().Set("Content-Type", "application/json")
-		file, _ := os.Open("fixtures/paginated_balance_accounts_response.json")
+		file, _ := os.Open("../fixtures/paginated_balance_accounts_response.json")
 		io.Copy(w, file)
 	})
 	mux.HandleFunc("/balanceAccounts/balanceAccountId/sweeps/sweepId", func(w http.ResponseWriter, r *http.Request) {
@@ -48,26 +46,11 @@ func Test_BalancePlatform(t *testing.T) {
 		require.Equal(t, "POST", r.Method)
 		// no response
 	})
-	mux.HandleFunc("/balanceAccounts/BA123/sweeps/SWPC123", func(w http.ResponseWriter, r *http.Request) {
-		assert.Contains(t, [2]string{"GET", "PATCH"}, r.Method)
-		w.Header().Set("Content-Type", "application/json")
-		file, _ := os.Open("fixtures/sweep.json")
-		io.Copy(w, file)
-	})
-	mux.HandleFunc("/transactionRules/transactionRuleId", func(w http.ResponseWriter, r *http.Request) {
-		require.Equal(t, "DELETE", r.Method)
-		w.Header().Set("Content-Type", "application/json")
-		file, _ := os.Open("fixtures/transaction_rule.json")
-		io.Copy(w, file)
-	})
+	mockResponse(http.StatusOK, "GET PATCH", "/balanceAccounts/BA123/sweeps/SWPC123", "sweep.json")
+	mockResponse(http.StatusOK, "DELETE", "/transactionRules/transactionRuleId", "transaction_rule.json")
+
 	// Error case
-	mux.HandleFunc("/paymentInstruments/666", func(w http.ResponseWriter, r *http.Request) {
-		require.Equal(t, "PATCH", r.Method)
-		w.Header().Set("Content-Type", "application/json")
-		w.WriteHeader(http.StatusUnprocessableEntity)
-		file, _ := os.Open("fixtures/not_found.json")
-		io.Copy(w, file)
-	})
+	mockResponse(http.StatusUnprocessableEntity, "PATCH", "/paymentInstruments/666", "not_found.json")
 
 	mockServer := httptest.NewServer(mux)
 	defer mockServer.Close()

diff --git a/tests/binlookup_test.go b/tests/binlookup_test.go
@@ -1,3 +1,6 @@
+//go:build integration
+// +build integration
+
 package tests
 
 import (

diff --git a/tests/checkoutidempotency_test.go → tests/checkout/idempotency_test.go b/tests/checkoutidempotency_test.go → tests/checkout/idempotency_test.go
@@ -1,4 +1,4 @@
-package tests
+package checkout
 
 import (
 	"context"