Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename parameters in HMAC validation IsValidWebhook() for Balance Platform #1056

Merged
merged 6 commits into from
Sep 9, 2024
Merged

Rename parameters in HMAC validation IsValidWebhook() for Balance Platform #1056

merged 6 commits into from
Sep 9, 2024

Conversation

DjoykeAbyah
Copy link
Member

@DjoykeAbyah DjoykeAbyah commented Sep 3, 2024 •
edited by Kwok-he-Chu
Loading

Context
Developers are currently passing the hmacKey in the signature parameter, vice versa signature was passed in the hmacKey parameter of the IsValidWebhook(...)-function. Let's rename these parameters accordingly, without changing the functionality.

Description
Rename hmacKey and signature parameters.

Tested scenarios

  • Verified the changes with existing unit tests:
    • TestBalancePlatformHmac remains unaffected

@DjoykeAbyah DjoykeAbyah requested a review from a team as a code owner September 3, 2024 11:07
@DjoykeAbyah DjoykeAbyah changed the title Fix is valid webhook Fix IsValidWebhook Sep 3, 2024
Kwok-he-Chu
Kwok-he-Chu requested changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@Kwok-he-Chu Kwok-he-Chu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I've added some minor suggestions below:

Adyen.Test/UtilTest.cs Outdated Show resolved Hide resolved
Kwok-he-Chu
Kwok-he-Chu requested changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@Kwok-he-Chu Kwok-he-Chu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some changes (improvements)

@Kwok-he-Chu Kwok-he-Chu changed the title Fix IsValidWebhook Fix HMAC validation IsValidWebhook() for Balance Platform Sep 5, 2024
Kwok-he-Chu
Kwok-he-Chu reviewed Sep 5, 2024
View reviewed changes
Adyen.Test/UtilTest.cs Outdated Show resolved Hide resolved
@Kwok-he-Chu Kwok-he-Chu changed the title Fix HMAC validation IsValidWebhook() for Balance Platform Rename parameters in HMAC validation IsValidWebhook() for Balance Platform Sep 9, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Kwok-he-Chu
Kwok-he-Chu approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@Kwok-he-Chu Kwok-he-Chu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done

@DjoykeAbyah DjoykeAbyah merged commit 670627c into main Sep 9, 2024
6 checks passed
@DjoykeAbyah DjoykeAbyah deleted the fix-IsValidWebhook branch September 9, 2024 10:34
@AdyenAutomationBot AdyenAutomationBot mentioned this pull request Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwok-he-Chu Kwok-he-Chu Kwok-he-Chu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DjoykeAbyah @Kwok-he-Chu