New: Add react-select component #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omgaz
force-pushed
the
add-react-select
branch
2 times, most recently
from
9407690 to
8d50cb4
Compare
omgaz
changed the title
omgaz
force-pushed
the
add-react-select
branch
3 times, most recently
from
f19d9d3 to
b4b89e1
Compare
Current coverage is
|
omgaz
force-pushed
the
add-react-select
branch
2 times, most recently
from
6e887ac to
0ceca31
Compare
| @@ -3,6 +3,7 @@ | |||
| require('styles/_bootstrap-custom.scss'); | |||
| require('styles/_icheck-custom.scss'); | |||
| require('styles/_react-toggle-custom.scss'); | |||
| require('styles/components/Select.scss'); | |||
There was a problem hiding this comment.
I think we should be using the same pattern as above (since its overriding styles for an existing component rather than a new custom component.
omgaz
force-pushed
the
add-react-select
branch
2 times, most recently
from
6b4cc46 to
3f1611f
Compare
| $select-input-border-color: $color-border-lighter; | ||
| $select-input-border-radius: $border-radius-base; | ||
| $select-input-border-focus: $select-input-border-color; | ||
| $select-input-height: 30px; |
There was a problem hiding this comment.
Just a coincidence that they're the same. It's 26 now anyway.
omgaz
force-pushed
the
add-react-select
branch
5 times, most recently
from
452ec9b to
232c1e6
Compare
|
LGTM |
- Custom style overrides - single and multi examples and tests - Downgraded sass naming convention errors to warnings until we can do inline/file based rules/exclusions - Added spacing between example components and removed unnecessary `<div>`s - `allowCreate` dependant on react-select PR 660 - Removed unnecessary box shadow length properties
omgaz
force-pushed
the
add-react-select
branch
from
232c1e6 to
4ef8323
Compare
|
LGTM 🍑 |
|
Merging! |
mcslash
added a commit
that referenced
this pull request
Jan 12, 2016
New: Add react-select component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using react-select this PR aims to integrate multi-select boxes into adslot-ui.
allowCreatedependant on react-select issue 660 (not linking directly because github seems to spam the projects issue with audits 🔈 )https://trello.com/c/MQGlB5Cs/4688-ad-hoc-react-select