Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: popover menu support #1582

Open
wants to merge 1 commit into
base: focus
Choose a base branch
from
Open

feat: popover menu support #1582

wants to merge 1 commit into from

Conversation

renrizzolo
Copy link
Contributor

refactor popover to support an external trigger element, add menu/focus management support

Description

Does this PR introduce a breaking change?

  • Yes
  • No

Manual testing step?

Screenshots (if appropriate):

@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #1582 (b1e3259) into focus (07a5dc7) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             focus     #1582   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           99       100    +1     
  Lines         1840      1920   +80     
  Branches       526       558   +32     
=========================================
+ Hits          1840      1920   +80     
Impacted Files Coverage Δ
src/components/HelpIconPopover/index.jsx 100.00% <ø> (ø)
src/components/Popover/WithRef.jsx 100.00% <ø> (ø)
src/components/HoverDropdownMenu/index.jsx 100.00% <100.00%> (ø)
src/components/Popover/Popper.jsx 100.00% <100.00%> (ø)
src/components/Popover/index.jsx 100.00% <100.00%> (ø)
src/components/Popover/usePopover.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant