fix: console warnings #1240
Open
fix: console warnings #1240
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1240 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 93 93
Lines 1377 1377
Branches 344 344
=========================================
Hits 1377 1377 Continue to review full report at Codecov.
|
chaofan232
commented
Oct 27, 2021
| @@ -4,16 +4,17 @@ import DesignNotes from '../containers/DesignNotes.jsx'; | |||
| ## User List Picker | |||
|
|
|||
| ```jsx live=true | |||
| const avatarColor = (user) => (user.avatar ? '' : 'cyan'); | |||
There was a problem hiding this comment.
The returned value is used as color props for Avatar component.
So, this method must return one of ['blue', 'green', 'red', 'orange', 'cyan', 'black'].
And as default if there is an image for Avatar component. the color will be not applied.
I just made another example to show how to use avatarColor() method.
vinteo
approved these changes
Oct 27, 2021
superpower1
approved these changes
Oct 28, 2021
adityasabnis
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Does this PR introduce a breaking change?
Manual testing step?
Screenshots (if appropriate):