Add simple Cursor variant of the DoesItVectorise example #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkraneis
changed the title
chriswhocodes
approved these changes
Oct 13, 2024
|
Thanks @rkraneis, sorry for the delay in getting around to merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open for discussion. Trying to find some good minimal Valhalla examples, this seemed to be a good start. I'm also looking into adding the "canonical" "Color" and "USDCurrency" examples.
This obviously needs the Valhalla early access JDK and
in
.mvn/jvm.configto run viamvn exec:java(see #390 for valueKeyRetention) as well as an appropriately configured sandbox.I tried the same with
LocalDate, but the interactions apparently were too complex for vectorization to kick in and using an explicitly declared value class makes it easier to play with just removingvalue.