Task #3711 - jre of the properties file does not work under windows #3
Conversation
- Check under windows against java.exe, instead of java, both in rust-launcher and in itweb-settings - Unmasking the colon at properties in the rust launcher
| File javaFile = new File(cmd + File.separator + "bin" + File.separator + "java"); | ||
| File javaFile = new File(cmd + File.separator + "bin" + | ||
| File.separator + "java" + | ||
| (JNLPRuntime.isWindows() ? ".exe" : "")); |
There was a problem hiding this comment.
Isn't this more spread? If so, maybe it can get its own function?
There was a problem hiding this comment.
Sorry i don't understand wath you mean with "Isn't this more spread?" I am not an English native speaker.
There was a problem hiding this comment.
Nor am I. I suspect that java part could forget .exe on more places. So maybe it would be good to ahve proper metho to appned .exe if necessary.
There was a problem hiding this comment.
All others I know are in the rust sources.
| @@ -85,7 +85,7 @@ fn check_file_for_property(file: File, key: &str) -> Option<String> { | |||
| None => {} | |||
| Some(kvv) => { | |||
| if kvv.key.eq(key) { | |||
| return Some(escape_unicode(kvv.value)); | |||
| return Some(escape_unicode(kvv.value.replace(r"\:", ":"))); | |||
There was a problem hiding this comment.
Can you please explain why it is necessary?
Will it not be soved by rust-lang/rust#27791 ? Which should be heading to stable soon.
There was a problem hiding this comment.
The colon is a delimiter for Java properties. Therefore it is masked during serialization. When used in Java getProperty, it will automatically unmask. In Rust you have to take care of the unmasking yourself. How it should help escape_unicode (), does not open to me.
There was a problem hiding this comment.
Colon xor equals is delimiter, depends what comes first. Isnt that?
There was a problem hiding this comment.
The following line has itweb-settings written in my deployments.properties.
deployment.jre.dir=C\:\\Program Files\\AdoptOpenJDK\\jdk-8.0.202.08\\jre
Here is the equal sign the delimiter, but java has masked the colon anyway. Without the replace, this is an invalid path, which will simply not be accepted.
https://icedtea.classpath.org/bugzilla/show_bug.cgi?id=3711