Skip to content

Commit

Permalink
Audience Network: upgrade bid requests to use latest SDK (prebid#3571)
Browse files Browse the repository at this point in the history
  • Loading branch information
lovell authored and harpere committed Feb 22, 2019
1 parent 849ae8f commit 88a7fe9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions modules/audienceNetworkBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const ttl = 600;
const videoTtl = 3600;
const platver = '$prebid.version$';
const platform = '241394079772386';
const adapterver = '1.2.0';
const adapterver = '1.3.0';

/**
* Does this bid request contain valid parameters?
Expand Down Expand Up @@ -108,7 +108,7 @@ const isFullWidth = format => format === 'fullwidth';
* @param {String} format
* @returns {String}
*/
const sdkVersion = format => isVideo(format) ? '' : '5.5.web';
const sdkVersion = format => isVideo(format) ? '' : '6.0.web';

/**
* Which platform identifier should be used?
Expand Down
8 changes: 4 additions & 4 deletions test/spec/modules/audienceNetworkBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const placementId = 'test-placement-id';
const playerwidth = 320;
const playerheight = 180;
const requestId = 'test-request-id';
const debug = 'adapterver=1.2.0&platform=241394079772386&platver=$prebid.version$&cb=test-uuid';
const debug = 'adapterver=1.3.0&platform=241394079772386&platver=$prebid.version$&cb=test-uuid';
const pageUrl = encodeURIComponent(utils.getTopWindowUrl());

describe('AudienceNetwork adapter', function () {
Expand Down Expand Up @@ -141,7 +141,7 @@ describe('AudienceNetwork adapter', function () {
requestIds: [requestId],
sizes: ['300x250'],
url: 'https://an.facebook.com/v2/placementbid.json',
data: `placementids[]=test-placement-id&adformats[]=300x250&testmode=false&pageurl=${pageUrl}&sdk[]=5.5.web&${debug}`
data: `placementids[]=test-placement-id&adformats[]=300x250&testmode=false&pageurl=${pageUrl}&sdk[]=6.0.web&${debug}`
}]);
});

Expand Down Expand Up @@ -179,7 +179,7 @@ describe('AudienceNetwork adapter', function () {
requestIds: [requestId],
sizes: ['728x90'],
url: 'https://an.facebook.com/v2/placementbid.json',
data: `placementids[]=test-placement-id&adformats[]=native&testmode=false&pageurl=${pageUrl}&sdk[]=5.5.web&${debug}`
data: `placementids[]=test-placement-id&adformats[]=native&testmode=false&pageurl=${pageUrl}&sdk[]=6.0.web&${debug}`
}]);
});

Expand All @@ -202,7 +202,7 @@ describe('AudienceNetwork adapter', function () {
requestIds: [requestId],
sizes: ['300x250'],
url: 'https://an.facebook.com/v2/placementbid.json',
data: `placementids[]=test-placement-id&adformats[]=300x250&testmode=false&pageurl=${pageUrl}&sdk[]=5.5.web&${debugPlatform}`
data: `placementids[]=test-placement-id&adformats[]=300x250&testmode=false&pageurl=${pageUrl}&sdk[]=6.0.web&${debugPlatform}`
}]);
});
});
Expand Down

0 comments on commit 88a7fe9

Please sign in to comment.