Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): Accept newer versions of CF_API_TOKEN/ACCOUNT_ID in deploy.yml #110

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

AdiRishi
Copy link
Owner

@AdiRishi AdiRishi commented Oct 1, 2023

Deploy.yml currently only accepted the deprecated versions of the api token and account id secrets.
This PR fixes that.

Summary by CodeRabbit

  • Chore: Updated GitHub Actions workflow in deploy.yml. The environment variables accountId and apiToken are now more flexible, allowing for the use of either the original secrets or new secrets (CLOUDFLARE_ACCOUNT_ID and CLOUDFLARE_API_TOKEN). This change enhances the flexibility of our deployment process by accommodating different sets of secrets depending on their availability.

@coderabbitai
Copy link

coderabbitai bot commented Oct 1, 2023

Walkthrough

The changes primarily focus on enhancing the flexibility of environment variables in the GitHub workflow. The accountId and apiToken variables are now updated to use either the original secrets or new secrets, allowing for a more adaptable deployment process.

Changes

File Summary
.github/workflows/deploy.yml Updated accountId and apiToken to use either original secrets or new secrets (CLOUDFLARE_ACCOUNT_ID and CLOUDFLARE_API_TOKEN). This enhances flexibility in using different sets of secrets depending on availability.

🐇💻

In the land of code where the shadows lie,

Secrets whisper, under the digital sky.

With a hop and a skip, changes we apply,

For better workflows, we constantly try.

So here's to the secrets, old and new,

To flexibility and options, we bid adieu! 🎉


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
  • Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
    resume reviews, enter @coderabbitai resume as any issue or review comment.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between bf43d39 and a53161d.
Files selected for processing (1)
  • .github/workflows/deploy.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/deploy.yml

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between bf43d39 and 2feaa9e.
Files selected for processing (1)
  • .github/workflows/deploy.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/deploy.yml

@AdiRishi AdiRishi merged commit 4da5b9b into master Oct 1, 2023
4 checks passed
@AdiRishi AdiRishi deleted the arishi-dev branch October 1, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant