This repository has been archived by the owner on Aug 26, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently it doesn't work outside dev. Gonna fix it tomorrow |
Dqu1J
suggested changes
Jul 9, 2021
I've tested all possible situations that can happen like stolen name conflict, original name conflict, attaching original name after registering non-original name etc. and everything works.. great mod improvement |
Dqu1J
approved these changes
Jul 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will test it later, thanks for contributing!
Fixed forced online auth. requiring registration when connecting
Dqu1J
added a commit
that referenced
this pull request
Jul 11, 2021
Please, see my message #14 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the "skip online auth." feature and introduces two replacements. Closes #14
(I'm going to refer to players with a valid license & account for Minecraft as 'official' and as 'unofficial' to those that don't have a license or account.)
forced-online-users
(an array of usernames) to select which players should use offline auth even if there is an official player with that name./onlineauth
command, effectively skipping/login
authentication.Note: Both features require the server to use online mode, although I think it could work in offline mode (if the
if
statements checking the online mode are removed from the code).Note: Both features give official players their UUID given by Mojang, allowing them to change their account username without losing data (in optional online auth. they have to run
/onlineauth
again). Unofficial players keep their offline-mode UUID.I don't know Russian, so I left the added messages in English