Fix keyUp event bug in ember-th #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chiaoyu-addepar the build is unblocked by #986. Please give this a rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
addon/components/ember-th/component.jsthere is a keyUp event which will triggerupdateSortfunction with Enter key. However, the current code will show the error in the below screen shot when user hitting Enter ( when focusing on the header columns )This PR is trying to fix this bug with providing a
toggle: falseinthis.updateSortwhen being called in the keyUp event.Reviewer note
not sure if we want to support the
togglethe same way as in the click eventlet toggle = event.ctrlKey || event.metaKey;