Upgrade ember-cli-addon-docs and friends #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
mixonic
force-pushed
the
mixonic/bump-ember-cli-addon-docs
branch
5 times, most recently
from
7d322c0
to
3b1a73b
Compare
twokul
reviewed
Feb 5, 2021
New versions of ember-cli-addon-docs bring a CSS reset which breaks ember-table tests. Instead of coupling the ember-table test suite to ember-cli-addon-docs CSS, I created a new ember try config for generating docs and removed the dependencies from the normal dev setup. I've documented how to generate the documentation in the README.md, and I believe updated the deployment/release code appropriately. Other changes related to the ember-cli-addon-docs upgrade include: * Add a dependency on ember-data since it no longer brings along the dependency. * Add newlines to account for bugs in ember-cli-addon-docs. See: ember-learn/ember-cli-addon-docs#473 and ember-learn/ember-cli-addon-docs#402 * Add a missing `END-SNIPPET` without which parsing of the snippet was corrupted. * Make an `hbs` template executable without error.
mixonic
force-pushed
the
mixonic/bump-ember-cli-addon-docs
branch
from
3b1a73b
to
d0030a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New versions of ember-cli-addon-docs bring a CSS reset which breaks ember-table tests. Instead of coupling the ember-table test suite to ember-cli-addon-docs CSS, I created a new ember try config for generating docs and removed the dependencies from the normal dev setup.
I've documented how to generate the documentation in the README.md, and I believe updated the deployment/release code appropriately.
Other changes related to the ember-cli-addon-docs upgrade include:
0.7.0ember-learn/ember-cli-addon-docs#473 and Using latest version breaks previous working markdown files ember-learn/ember-cli-addon-docs#402END-SNIPPETwithout which parsing of the snippet was corrupted.hbstemplate executable without error.