Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to released version of ember-cli-page-object v2 #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ascudder
Copy link
Contributor

Upgrades the version of ember-cli-page-object from the beta version (~v2.0.0-beta.3) to the stable released version (^2.1.0) so that it is compatible with a wider range of ember-cli-page-object versions. Additionally, updates
the engines specification to match the compatibility of ember-cli-page-object.

@mixonic
Copy link
Member

mixonic commented Sep 8, 2023

Awesome. Yeah IIRC the reason this was pinned to the beta was because the dependency had dropped support for a version of Ember still supported by Ember Table (and used by Addepar at the time).

Happily that is no longer the case, and we will be cutting a new major of Ember Table Addepar/ember-table#995 with support for only Ember 3.28+ in the coming weeks.

Let me check if this seems like it is unblocked, and if so I could merge this and cut a new minor version (non beta) with this change.

@ascudder
Copy link
Contributor Author

ascudder commented Sep 8, 2023

Thanks @mixonic for taking a look and for the explanation on compatibility. Fortunately it looks like we're already on a compatible version of Ember, so If this can make it into a pre-release version of the next release, that would help us out, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants