Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the legacy style build steps #38

Merged
merged 2 commits into from
Jul 31, 2020

Conversation

mixonic
Copy link
Member

@mixonic mixonic commented Jul 31, 2020

Opened as a PR, but we should not merge this.

  • 0.7.5 was never released, although there is a commit referencing it.
  • I propose to release this branch as 0.8.0 (edited from 0.7.6 at @bantic's suggestion)
  • Then I propose we merge this into master
  • Then I propose we cut 0.8.1 with the unreleased "0.7.5" content and the contents of this page.

Drop a bunch of legacy build stuff. Stop requiring sass to be installed, just require ember-cli-sass which should permit the consumer to decide which sass implementation to use.

Drop autoprefixer because consuming apps can pick what to do on their own.

Drop some default postcss options because they make old assumptions about browser compat, and presume postcss is even used by a consumer.

@mixonic mixonic requested a review from a team July 31, 2020 19:10
@mixonic mixonic force-pushed the mixonic/drop-legacy-style-build-steps branch from cbf625c to f60511f Compare July 31, 2020 19:24
@mixonic mixonic force-pushed the mixonic/drop-legacy-style-build-steps branch from f60511f to cb962b0 Compare July 31, 2020 19:35
@bantic
Copy link

bantic commented Jul 31, 2020

The dropping of node-sass-import-once in v0.7.4 (https://github.com/Addepar/addepar-style-toolbox/pull/31/files) ought to have made it a bigger version change, imo. It changes how the sass is compiled for consumers that use @import, and could break client styles (as it did for our consuming app, for example).

I think we should release this branch as 0.8.0 and the follow-up merge-to-master as 0.8.1.

Copy link

@bantic bantic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I think that we should start any new versions based on 0.7.4 code at 0.8.0, as I mentioned in the comment

@mixonic mixonic merged commit a85f464 into master Jul 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the mixonic/drop-legacy-style-build-steps branch July 31, 2020 20:30
@mixonic
Copy link
Member Author

mixonic commented Jul 31, 2020

0.8.0 released with the SHA of this branch, then I merged it into master manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants