-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Canvas.DrawImage (#784) #878
Conversation
Thanks! Finally managed to look into this again and update the review. Instead of requesting a few more changes, I took the time to add them myself right away, to avoid going stale again, since I think this is a pretty useful feature. Some of the changes were not part of earlier review requests and only occurred to me when doing a more thorough review today, checking out the most recent changes. I know it's not the cleanest way to go through with this PR, but right now it's the best I can manage, given the limited time I have - sorry about that, but I hope that's fine with you. Changes I made and rationale behind them:
|
As per #784, this introduces a DrawImage(Material / BatchInfo) to the Canvas.
The code has been taken inspiration from FillRect, but feel free to add suggestions on how it can be improved