-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project settings and move launcher path to it #852
Conversation
05409dd
to
7407803
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me, just a little thing bugging my brain: we have UserData and AppData, so why not ProjectData? 😄
1975baa
to
bba1cdb
Compare
To me, ProjectSettings just triggers the right associations as to what one should expect to find inside, and it's a term that's well known from other software and Unity. It's also too different from |
bba1cdb
to
23907a7
Compare
@ilexp when publishing the game editor files wouldn't be included right? We have a number of different settings files: For the game:
For the editor:
And some default variants of these files. We might wanna look into cleaning this up so we treat all these settings in the same way but thats for a different issue #855. I agree with sirepi that the naming for |
It depends - it's perfectly valid to deploy the editor with the game to give players a map editor or something. In that case, the project settings / (non-user) editor settings would be included as well. Perhaps cleaned up in some form, but that's a separate issue for later I think.
I still think Edit: Maybe let's move this discussion over to #855? I've commented there with some more thoughts on this. For this PR I'm fine with either choice as long as you guys come to an agreement 👍
It's non-global / per-object data that is only relevant in the editor, see here. Right now it only stores whether an object is locked or hidden. Could probably be refactored to be merged into any of the other files, depending on how we define the scope of this info, or stay separate for a while until we happen across a good idea on what else to do with it. |
For now I will keep the name as is in this PR. Lets change the name to the final name after discussing it in the issue. |
No description provided.