Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#634: removing solution level packages #635

Merged
merged 2 commits into from
Mar 20, 2018
Merged

#634: removing solution level packages #635

merged 2 commits into from
Mar 20, 2018

Conversation

Barsonax
Copy link
Member

No description provided.

@Barsonax Barsonax changed the title #634 #634: removing solution level packages Mar 19, 2018
@ilexp ilexp added Core Area: Duality runtime or launcher Cleanup Improving form, keeping function labels Mar 19, 2018
@ilexp ilexp added this to the General milestone Mar 19, 2018
Copy link
Member

@ilexp ilexp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

# Visual Studio 2013
VisualStudioVersion = 12.0.40629.0
# Visual Studio 15
VisualStudioVersion = 15.0.27428.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically not a clean PR with this change, as updating the VS version of the solution could backfire and wasn't part of the issue - but I'll take this as it make sense to update the solution version by now. Would prefer a more selective PR next time though 🙂

@ilexp ilexp merged commit c260bba into AdamsLair:master Mar 20, 2018
@ilexp
Copy link
Member

ilexp commented Mar 20, 2018

Merged. Thanks!

@Barsonax Barsonax deleted the #634 branch October 31, 2018 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Improving form, keeping function Core Area: Duality runtime or launcher
Development

Successfully merging this pull request may close these issues.

2 participants