Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip ignored users during group sync #41

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

vigen-b
Copy link
Contributor

@vigen-b vigen-b commented Dec 25, 2023

Description

Fix for #40

What's Changed

  • skip ignored users when syncing groups

@Adambean
Copy link
Owner

Adambean commented Dec 25, 2023

Thanks for submitting this. I think the code is correct, spot on in fact. :) I'm checking if it's perhaps happening at the wrong place.

This change will resolve ignored users being unintentionally deleted from a user group, which is fine, though perhaps this check should happen sooner to avoid ignored users being added to a group too. I'll check what happens if your amendment is positioned at line 1874 instead, just after the check for built-in user names, as these two checks are often paired up. You could be completely correct where it already is though.

@Adambean Adambean self-requested a review December 25, 2023 14:08
@Adambean Adambean self-assigned this Dec 25, 2023
@vigen-b
Copy link
Contributor Author

vigen-b commented Dec 26, 2023

Seems it's better idea, at least user skipping would be handled in one place.

Copy link
Owner

@Adambean Adambean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine.

@Adambean Adambean merged commit 74b5a15 into Adambean:master Jan 23, 2024
@vigen-b vigen-b deleted the fix-group-sync-for-ignored-users branch January 24, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants