-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitlab LDAP sync script tries to remove "bot" users from groups. #44
Comments
|
I've not looked yet, but I suspect the users API will be able to reveal if a user is a bot. We could then exclude bot users from deletions. (I noticed this happening at our corporate Gitlab too, though I've only ever needed to run the tool once here so far.) |
Reformatted the Title. I first noticed it with groups that did not match a LDAP group name. But it is happening with all groups. |
According to the documentation the "bot" property is only returned when querying the API for a single user, not in the response when querying for multiple users. I'll check if that's true. |
I've added a branch issue/19-script-tries-to-remove-bots-from-groups you can switch to to see if this works for you. (Dry run first of course.) |
@Adambean without_project_bots default is false... |
The Gitlab LDAP sync script tries to currently remove "bot users" that are created when adding an
access_token
from non-ldap groups. Maybe even from groups that are also present in LDAP.https://gitlab.example.com/groups/<GROUPNAME>/-/settings/access_tokens
The text was updated successfully, but these errors were encountered: