Feature to intelligently fill corners #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fill the corners of the cards using their own edges, allowing filled border for cards of any border color. - make filled corners for borderless cards look good as well. - make the border-filling finctions static - rename CLI functions to generic names - designate output destination for tests
- since for each corner, the code gets executed similarly, make the methods share code as much as possible - add docstrings - fix method name shadowing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corners will be filled by taking pixels patches from the card close to the corners and covering the transparent areas with it.
This way it is able to fill the corners of any color and, to some extent, border-less cards as well.