ref: rewrite for flexibility and readability #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
AdamBajger
commented
May 8, 2024
AdamBajger
commented
- add abstract class for card printers (FPDF2 and Matplotlib) to reduce redundant code
- remove globals, add docstrings, add typing
- introduce RUFF for linting and stuff
- add example cards for offline development/testing
- update from setup.py to pyproject.toml - use pdm - add support for "x" after the numbers in the decklists
- add a dedicated module for sizes and dimensions - add nptyping for better typehints
- remove pdf case from matplotlib function, since PDF output is handled by a separate method - add cache CLI argument for the following cache refactor - fix methods being shadowed by their local variables - replace Argparse with CLick - rewrite dimensions for better accessibility - decompose printing methods into classes for better extensibility
- modify cache location - add cache argument to each function that uses it to remove cache definition through side effects (globals are 'ew'!) - add some tests for units and dimensions
- add conftest for fixtures - fix some broken tests -
- add conftest for fixtures - fix broken tests - remove obsolete tests - change str -> Path where applicable - fix matplotlib plotting and FPDF2 printing issues, including issues rooted in the abstract base class.
- use the faster better RUFF instead of older things. - add conventional commits hook to encourage readable reflogs - add example card images for testing and offline development
- fix pre-commit dependency and stuff - remove invalid import - update README.md - update deps in pyproject.toml - remove prettier
- use correct fixtures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.