Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff.py(diff): make number of context lines configurable #661

Conversation

glacambre
Copy link
Contributor

No description provided.

@glacambre glacambre force-pushed the wip/make-number-of-diff-context-lines-configurable branch from 37248e2 to e580ba5 Compare December 18, 2023 10:14
@glacambre
Copy link
Contributor Author

@enzbang I don't know who would be the right reviewer for this and you're the last person who touched this code. Could you have a look, or assign the right reviewer? (I don't have enough permissions to assign reviewers.)

@enzbang enzbang requested a review from leocardao December 18, 2023 10:37
src/e3/diff.py Outdated Show resolved Hide resolved
@grouigrokon grouigrokon self-requested a review December 18, 2023 15:16
grouigrokon
grouigrokon previously approved these changes Dec 18, 2023
src/e3/diff.py Show resolved Hide resolved
@glacambre glacambre force-pushed the wip/make-number-of-diff-context-lines-configurable branch from e580ba5 to a8dbd07 Compare December 18, 2023 16:30
@glacambre glacambre force-pushed the wip/make-number-of-diff-context-lines-configurable branch from a8dbd07 to 33c6897 Compare December 18, 2023 16:34
@leocardao leocardao merged commit 28fb01a into AdaCore:master Jan 5, 2024
9 checks passed
@pmderodat
Copy link
Member

Hello! Would it be possible to publish a new e3-core release so that e3-testsuite can use this new feature? Thanks!

@liaiss
Copy link
Contributor

liaiss commented Jan 16, 2024

Hello! Would it be possible to publish a new e3-core release so that e3-testsuite can use this new feature? Thanks!

you means in the package registry, right?

@pmderodat
Copy link
Member

Yes, on Pypi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants